Skip to content

[v18.x] test, v8: fix wrong import attributes test #52184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolo-ribaudo wants to merge 2 commits into from
Closed

[v18.x] test, v8: fix wrong import attributes test #52184

nicolo-ribaudo wants to merge 2 commits into from

Conversation

@nicolo-ribaudo
Copy link
Contributor

@nicolo-ribaudo nicolo-ribaudo commented Mar 21, 2024 •
edited
Loading

Ref #52165 (comment)

@richardlau I believe this fixes it, but I'm not 100% sure because I couldn't figure out how to run V8 tests locally. Do you have any pointers?

I will then submit the same patch to V8.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 21, 2024

Review requested:

  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. v8 engine Issues and PRs related to the V8 dependency. labels Mar 21, 2024
@richardlau
Copy link
Member

richardlau commented Mar 21, 2024

CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/5864/

Looks like tests are still failing:
e.g. https://ci.nodejs.org/job/node-test-commit-v8-linux/5864/nodes=rhel8-s390x,v8test=v8test/console

21:16:41 === mjsunit/harmony/modules-import-assertions-3 ===
21:16:41 --- stdout ---
21:16:41 undefined:0: Error: d8: Error reading  module from /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/harmony/modules-skip-imports-json-assert-1.mjs
21:16:41     imported by /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/harmony/modules-import-assertions-3.mjs
21:16:41 Command: /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/out.gn/s390x.release/d8 --test /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/mjsunit.js /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/harmony/modules-import-assertions-3.mjs --random-seed=-1513086391 --nohard-abort --testing-d8-test-runner --harmony-import-assertions
21:16:41 === mjsunit/harmony/modules-import-assertions-dynamic-5 ===
21:16:41 --- stdout ---
21:16:41 undefined:0: <string conversion failed>
21:16:41 
21:16:41 
21:16:41 MjsUnitAssertionError
21:16:41     at assertEquals /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/mjsunit.js 442:7
21:16:41     at              /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/harmony/modules-import-assertions-dynamic-5.mjs 12:1
21:16:41 Command: /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/out.gn/s390x.release/d8 --test /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/mjsunit.js /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/harmony/modules-import-assertions-dynamic-5.mjs --random-seed=-1513086391 --nohard-abort --testing-d8-test-runner --allow-natives-syntax --harmony-import-assertions
21:16:41 === mjsunit/harmony/modules-import-attributes-3 ===
21:16:41 --- stdout ---
21:16:41 undefined:0: Error: d8: Error reading  module from /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/harmony/modules-skip-imports-json-with-1.mjs
21:16:41     imported by /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/harmony/modules-import-attributes-3.mjs
21:16:41 Command: /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/out.gn/s390x.release/d8 --test /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/mjsunit.js /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/harmony/modules-import-attributes-3.mjs --random-seed=-1513086391 --nohard-abort --testing-d8-test-runner --harmony-import-attributes
21:16:41 === mjsunit/harmony/modules-import-attributes-dynamic-5 ===
21:16:41 --- stdout ---
21:16:41 undefined:0: <string conversion failed>
21:16:41 
21:16:41 
21:16:41 MjsUnitAssertionError
21:16:41     at assertEquals /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/mjsunit.js 442:7
21:16:41     at              /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/harmony/modules-import-attributes-dynamic-5.mjs 12:1
21:16:41 Command: /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/out.gn/s390x.release/d8 --test /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/mjsunit.js /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/harmony/modules-import-attributes-dynamic-5.mjs --random-seed=-1513086391 --nohard-abort --testing-d8-test-runner --allow-natives-syntax --harmony-import-attributes
21:16:41 
21:16:41 ===
21:16:41 === 4 tests failed
21:16:41 ===

I couldn't figure out how to run V8 tests locally. Do you have any pointers?

If you're on x64 (or s390x or ppc64le but I suspect not 🙂) you should be able to run make test-v8. I think you now need ninja/ninja-build installed (V8 used to fetch this as a dependency but I don't think it does anymore). Our CI is running:

export 'VPYTHON_BYPASS=manually managed python not supported by chrome operations'
make -j 88 test-v8 V=1 DESTCPU=x64 ARCH=x64.release ENABLE_V8_TAP=True 'V8_EXTRA_TEST_OPTIONS=--progress=dots --timeout=120 intl'

@richardlau richardlau changed the title test, v8: fix wrong import attributes test [v18.x] test, v8: fix wrong import attributes test Mar 21, 2024
@nicolo-ribaudo
Copy link
Contributor Author

nicolo-ribaudo commented Mar 21, 2024

I had just renamed the files in one way, and updated the import paths in a different one 🤦

(Tests locally are still running)

@nicolo-ribaudo
Copy link
Contributor Author

nicolo-ribaudo commented Mar 21, 2024

Ok I run those 4 tests manually (running the full V8 tests suite was taking too long) and they are passing -- could you re-run CI?

@richardlau richardlau added request-ci Add this label to start a Jenkins CI on a PR. fast-track PRs that do not need to wait for 48 hours to land. labels Mar 22, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2024

Fast-track has been requested by @richardlau. Please 👍 to approve.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 22, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 22, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/57885/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 22, 2024

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5867/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 22, 2024

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5867/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 22, 2024

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5867/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 22, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/57887/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 22, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/57889/

@joyeecheung
Copy link
Member

joyeecheung commented Mar 22, 2024

BTW the failure on https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5867/ can be ignored because it’s network issue in the nearform-hosted machine which has been happening for a year? already…

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 22, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/57898/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 22, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/57901/

@richardlau
Copy link
Member

richardlau commented Mar 22, 2024

BTW the failure on https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5867/ can be ignored because it’s network issue in the nearform-hosted machine which has been happening for a year? already…

FWIW I requested a V8 CI run for this PR before approving which passed everywhere: https://ci.nodejs.org/job/node-test-commit-v8-linux/5866/
Adding the request-ci label started another V8 CI run (the one quoted).

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 22, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/57905/

@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 22, 2024
@richardlau richardlau removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 22, 2024
@richardlau
Copy link
Member

richardlau commented Mar 22, 2024

Landed in 931d02f.

@richardlau richardlau closed this Mar 22, 2024
@nicolo-ribaudo nicolo-ribaudo deleted the fix-v18-import-attributes-backport branch March 22, 2024 16:35
@richardlau richardlau mentioned this pull request Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@richardlau richardlau richardlau approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nicolo-ribaudo @nodejs-github-bot @richardlau @joyeecheung @GeoffreyBooth @marco-ippolito