Skip to content

bpo-37483: fix refleak #14599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
methane wants to merge 2 commits into from
Closed

bpo-37483: fix refleak #14599

methane wants to merge 2 commits into from

Conversation

@methane
Copy link
Member

@methane methane commented Jul 5, 2019 •
edited by bedevere-bot
Loading

@methane methane added skip news type-bug An unexpected behavior, bug, or error labels Jul 5, 2019
jdemeyer
jdemeyer requested changes Jul 5, 2019
View reviewed changes
Copy link
Contributor

@jdemeyer jdemeyer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to initialize v = NULL and you need to handle the case v == NULL in onError. See #14600

@methane methane closed this Jul 5, 2019
@methane methane deleted the fix-refleak branch July 5, 2019 10:23
@methane methane restored the fix-refleak branch July 5, 2019 10:24
@methane methane reopened this Jul 5, 2019
@methane
Copy link
Member Author

methane commented Jul 5, 2019

You need to initialize v = NULL and you need to handle the case v == NULL in onError. See #14600

Why?

    v = normalizestring(encoding);
    if (v == NULL)
        goto onError;
    PyUnicode_InternInPlace(&v);

@methane methane closed this Jul 5, 2019
@methane
Copy link
Member Author

methane commented Jul 5, 2019

I'm sorry, I found it myself.

@methane methane deleted the fix-refleak branch July 5, 2019 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdemeyer jdemeyer jdemeyer requested changes

Assignees

No one assigned

Labels

awaiting core review skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@methane @jdemeyer @the-knights-who-say-ni @bedevere-bot