bpo-41270: Making NamedTemporaryFile act as its own iterator to mimic… #22766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… normal file objects. NamedTemporaryFile returns a proxy object _TemporaryFileWrapper. However it does not proxy the __next__ method so the object cannot be used by for loops or by the next() builtin without calling iter() on it first. This changes that by explicity poxying the __next__ method.
Merged
3 tasks
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days |
Author
|
@jstasiak this has been sitting for a while. Is there any update? |
Contributor
|
@xzy3 I'm dorry, I'm not a core dev, I can't do anything other than reviewing this. |
github-actions
bot
removed
the
stale
|
Following the issue migration to GitHub, this PR would close #85442. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… normal file objects.
NamedTemporaryFilereturns a proxy object_TemporaryFileWrapper. However it does not proxythe
__next__method so the object cannot be used by for loops or by thenext()builtinwithout calling
iter()on it first. This changes that by explicitly poxying the__next__method.
https://bugs.python.org/issue41270