build: look for libnode.so in lib subdirectory - #58213
Merged
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building with
--shared,ninjawill output thelibnode.sointo a{build_dir}/libdirectory, not in the root{build_dir}. This fixes the install script to look for it in the correct place.Found during review of a Fedora rpm, where we apparently been moving the
libnode.somanually to the root of the build directory manually this entire time. Let's see if we can stop doing that. 😅