Conversation
rustbot
added
the
S-waiting-on-review
rustbot
added
the
T-compiler
Collaborator
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use Why was this reviewer chosen?The reviewer was selected based on:
|
fee1-dead
requested changes
Aug 26, 2026
|
|
||
| #![feature(min_generic_const_args)] | ||
| #![feature(generic_const_args)] | ||
| //~^ ERROR:`generic_const_args` requires -Znext-solver=globally to be enabled |
Member
There was a problem hiding this comment.
Suggested change
| //~^ ERROR:`generic_const_args` requires -Znext-solver=globally to be enabled | |
| //~^ ERROR: `generic_const_args` requires -Znext-solver=globally to be enabled |
|
|
||
| fn check_features_requiring_new_solver(sess: &Session, features: &Features) { | ||
| if sess.opts.unstable_opts.next_solver.globally { | ||
| if sess.opts.unstable_opts.next_solver.globally && !features.generic_const_exprs() { |
Member
There was a problem hiding this comment.
Are we sure this is the right way to do it? Shouldn't we really just emit an error when GCE and next_solver are both enabled instead of a warning? Downgrading next solver to coherence only appears the wrong approach.
What if we removed GCE as a feature?
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, enabling
generic_const_exprsdisabled the next solver, but also enablinggeneric_const_argswas not rejected even though it required the next solver.Fixes #161523.