Skip to content

handle trait solver overflow when checking mono item instantiability - #162467

Open
amirHdev wants to merge 3 commits into
rust-lang:mainfrom
amirHdev:impossible-impl-mono-items
Open

handle trait solver overflow when checking mono item instantiability#162467
amirHdev wants to merge 3 commits into
rust-lang:mainfrom
amirHdev:impossible-impl-mono-items

Conversation

@amirHdev

@amirHdev amirHdev commented Sep 8, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

fixes #162343

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Sep 8, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@amirHdev
amirHdev force-pushed the impossible-impl-mono-items branch from 6251c6f to 96924c2 Compare September 8, 2026 15:03
@rust-log-analyzer

This comment has been minimized.

Sign in to view
bjorn3
bjorn3 reviewed Sep 8, 2026
View reviewed changes
Comment thread compiler/rustc_monomorphize/src/collector.rs Outdated
@amirHdev
amirHdev force-pushed the impossible-impl-mono-items branch 2 times, most recently from 6a85c5f to 357cb68 Compare September 9, 2026 07:43
@amirHdev
avoid collecting uninstantiable mono items
01e1c99 
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
@amirHdev
amirHdev force-pushed the impossible-impl-mono-items branch from 357cb68 to 01e1c99 Compare September 9, 2026 07:47
@amirHdev
amirHdev marked this pull request as ready for review September 9, 2026 07:48
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 9, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 9, 2026
@rustbot

rustbot commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 76 candidates
  • Random selection from 22 candidates

@amirHdev

amirHdev commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

r? bjorn3

@rustbot rustbot assigned bjorn3 and unassigned wesleywiser Sep 9, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bjorn3

bjorn3 commented Sep 9, 2026

Copy link
Copy Markdown
Member

I don't know much about the trait solver. Not sure if this code is part of the new trait solver, but I would assume people working on the new trait solver do know about this function:

r? rust-lang/initiative-trait-system-refactor

@rustbot

rustbot commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Team or group rust-lang/initiative-trait-system-refactor not found.

rust-lang team names can be found at https://github.com/rust-lang/team/tree/master/teams.
Reviewer group names can be found in triagebot.toml in this repo.

@bjorn3

bjorn3 commented Sep 9, 2026

Copy link
Copy Markdown
Member

r? project-trait-system-refactor

@rustbot rustbot assigned lqd and unassigned bjorn3 Sep 9, 2026
@amirHdev
handle trait solver overflow during mono item collection
6314922 
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
@lqd

lqd commented Sep 9, 2026

Copy link
Copy Markdown
Member

r? types

@rustbot rustbot added the T-types Relevant to the types team, which will review and decide on the PR/issue. label Sep 9, 2026
@rustbot rustbot assigned spastorino and unassigned lqd Sep 9, 2026
@amirHdev amirHdev changed the title handle unresolved direct calls during mono item collection handle trait solver overflow when checking mono item instantiability Sep 9, 2026
@amirHdev
keep symbol exports in sync with mono item instantiability
a1395fa 
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@spastorino spastorino

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-types Relevant to the types team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ICE]: corecursive trait solver failure with lifetimes

7 participants

@amirHdev @rust-log-analyzer @rustbot @bjorn3 @lqd @spastorino @wesleywiser