[6.x] Fix custom term templates on collection-scoped term URLs - #15351
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019Qb7v84sX9yTT8Nso7nrw7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where setting a custom term template on a taxonomy (eg.
term_template: taxonomy/term) caused collection-scoped term URLs like/blog/tags/footo 404, while/tags/fooand/blog/tagscontinued to work.This was happening because
LocalizedTerm::template()always prefixed the taxonomy's term template with the collection handle when the term was scoped to a collection, producingblog.taxonomy/term. That view never exists, so theview()->exists()check intoResponse()failed. The taxonomy index didn't have this problem sinceTaxonomy::template()already returns a custom template as-is.This PR fixes it by only adding the collection prefix when the taxonomy is using its conventional default term template, so a custom
term_templateis used as-is for both/tags/fooand/blog/tags/foo.Fixes #10478