[6.x] Fix Bard sets showing the wrong values after saving - #15445
Merged
Merged
Conversation
saving with `cmd+s` keeps the editor focused, so the `value` watcher never rebuilt it from the response. with `remove_empty_nodes` stripping paragraphs, the sets ended up pointing at the wrong indexes in the value. the focus guard now only skips changes confined to set values, which sets sync themselves. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EgVCmXDcwKKNQP6EgpPUaA
duncanmcclean
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where Bard sets would show the next set's values after saving, when the field has
remove_empty_nodesenabled. Saving a second time would then write those wrong values to the entry.This was happening because the
valuewatcher skips rebuilding the editor from the save response while the editor is focused. Withremove_empty_nodes: true, the server had stripped the empty paragraphs, so the sets in the editor were pointing at the wrong indexes in the saved value.This PR fixes it by only skipping the rebuild while focused when the change is confined to set values (which sets sync into the editor themselves). Anything else rebuilds the editor, like it does when the editor isn't focused.
Fixes #15440
Caused by #14808