[6.x] Fix error response codes sticking to later pages in long-lived processes - #15454
Merged
jasonvarga merged 1 commit intoSep 14, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When rendering an HTTP error page,
RendersHttpExceptions::contents()registers aCascade::hydrated()callback to setresponse_code. The problem is, that response code is currently sticky in long-lived processes (e.g. Octane). For example, after a single 404, every later page rendered by that process reports the error code in its cascade.How we prevent response codes sticking between requests
Add a new method to handle situations where we want to register a callback that can only be consumed once, but is then removed. It's similar to flash messages in regular PHP applications ("after consumed once, delete"). Then, we use that new method for the response code callback.