Skip to content

Rename output length params to outputLength - #52

Merged
twiss merged 1 commit into
mainfrom
outputLength-param
Feb 16, 2026
Merged

twiss merged 1 commit into
mainfrom
outputLength-param

Conversation

@twiss

@twiss twiss commented Feb 15, 2026

Copy link
Copy Markdown
Collaborator

Rename the cSHAKE and KMAC parameters for the output length from length to outputLength, to avoid confusion with the key length parameters in Web Crypto also named length.


Preview | Diff

Rename the cSHAKE and KMAC parameters for the output length from
`length` to `outputLength`, to avoid confusion with the key length
parameters in Web Crypto also named `length`.

@panva panva left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you make a corresponding WPT update?

@twiss

twiss commented Feb 15, 2026

Copy link
Copy Markdown
Collaborator Author

Yeah, will do 👍

@twiss

twiss commented Feb 15, 2026

Copy link
Copy Markdown
Collaborator Author

P.S. Cc to @tete17 and @kkoyung since you have an implementation of cSHAKE and this is a breaking change, let me know if you have any objections.

@kkoyung

kkoyung commented Feb 16, 2026

Copy link
Copy Markdown
Contributor

LGTM

@twiss
twiss merged commit 4143489 into main Feb 16, 2026
2 checks passed
@twiss
twiss deleted the outputLength-param branch February 16, 2026 10:00
github-actions Bot added a commit that referenced this pull request Feb 16, 2026
SHA: 4143489
Reason: push, by twiss

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants