Skip to content

Conversation

@westonruter
Copy link
Member

@westonruter westonruter commented May 31, 2024

Fixes #1222

As suggested by @justlevine in #1222 (comment):

Has adopting the design language from the Plugin Dependencies feature already been discussed and discarded?

A standard Note: This plugin was installed by... that's below the plugin meta, similar in style to the new Note: this plugin cannot be activated or deactivated..., would provide a straightforward solve without worrying about prefixes, slug lengths, metadata density, or over/underengineering

Here's what that looks like in WP 6.5+:

Before After
Screenshot 2024-05-31 12 19 31 Screenshot 2024-05-31 12 19 46

The Performance Lab link goes to the Performance settings screen.

Note that I chose to say "This plugin is installed" as opposed to "This plugin was installed" because we don't keep track of whether or not a given feature plugin was indeed installed by the Performance Lab plugin. So it is intended to say that the Performance Lab in general installs a given feature plugin, but that's not to say it couldn't be installed directly.

@westonruter westonruter added [Type] Enhancement A suggestion for improvement of an existing feature [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only labels May 31, 2024
@westonruter westonruter added this to the performance-lab 3.2.0 milestone May 31, 2024
@github-actions
Copy link

github-actions bot commented May 31, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: westonruter <[email protected]>
Co-authored-by: mukeshpanchal27 <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: ThierryA <[email protected]>
Co-authored-by: joemcgill <[email protected]>
Co-authored-by: ashwinparthasarathi <[email protected]>
Co-authored-by: justlevine <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Co-authored-by: Pascal Birchler <[email protected]>
Co-authored-by: Pascal Birchler <[email protected]>
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. The code shows error so i have push 5019dd5 that fixed the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Indicate plugins in list table which are installed by Performance Lab

5 participants