Skip to content

Conversation

@westonruter
Copy link
Member

The Web Worker Offloading plugin is now live! https://wordpress.org/plugins/web-worker-offloading/

This adds the plugin to the list of experimental performance features to activate:

image

Note the modification of the per_page field is simply to bust the WordPress.org API response cache, as otherwise the plugin is not currently included in the results and the screen is:

Screenshot 2024-10-03 12 02 06

I'm not sure how long the responses are cached. Perhaps in another hour it will be flushed.

@westonruter westonruter added [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Plugin] Web Worker Offloading Issues for the Web Worker Offloading plugin. labels Oct 3, 2024
@westonruter westonruter added this to the performance-lab n.e.x.t milestone Oct 3, 2024
@westonruter westonruter self-assigned this Oct 3, 2024
@github-actions
Copy link

github-actions bot commented Oct 3, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: westonruter <[email protected]>
Co-authored-by: felixarntz <[email protected]>
Co-authored-by: mukeshpanchal27 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@westonruter Mostly looks good, except the hack, see below.

Also worth noting that the description of the plugin doesn't look right. At a minimum, it should also start with a third-person singular verb like all the other descriptions. Additionally, we should consider making the description more meaningful to an end user - for instance it could lead to the question "why would it help to offload scripts to a webworker?"

'author' => 'wordpressdotorg',
'tag' => 'performance',
'per_page' => 100,
'per_page' => 99, // Decremented from 100 to bust WordPress.org response cache.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit of a strange workaround. 🙃

I think we can omit this, the cache should refresh soon enough.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should hopefully. Still cached as of now. We can leave this open until the cache expires I guess.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure this won't be relevant anymore by the time we release this 😆

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cache still not expired! Wow. I wonder if it only is invalidated once one of the plugins in the response is touched.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I should directly commit the description update to the 0.1.0 tag to see if that invalidates it.

@westonruter
Copy link
Member Author

westonruter commented Oct 3, 2024

Also worth noting that the description of the plugin doesn't look right. At a minimum, it should also start with a third-person singular verb like all the other descriptions. Additionally, we should consider making the description more meaningful to an end user - for instance it could lead to the question "why would it help to offload scripts to a webworker?"

How about 28b0628?

Update: 4fc8751

@westonruter westonruter added the [Type] Enhancement A suggestion for improvement of an existing feature label Oct 3, 2024
@felixarntz
Copy link
Member

Also worth noting that the description of the plugin doesn't look right. At a minimum, it should also start with a third-person singular verb like all the other descriptions. Additionally, we should consider making the description more meaningful to an end user - for instance it could lead to the question "why would it help to offload scripts to a webworker?"

How about 28b0628?

That description for WWO looks good to me! Note that it looks like you accidentally updated the Image Prioritizer description too?

@westonruter westonruter force-pushed the add/web-worker-offloading-to-features branch from 28b0628 to 4fc8751 Compare October 3, 2024 20:02
@mukeshpanchal27 mukeshpanchal27 merged commit ba60dbc into trunk Oct 4, 2024
@mukeshpanchal27 mukeshpanchal27 deleted the add/web-worker-offloading-to-features branch October 4, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Plugin] Web Worker Offloading Issues for the Web Worker Offloading plugin. [Type] Enhancement A suggestion for improvement of an existing feature

Projects

Status: Done 😃

Development

Successfully merging this pull request may close these issues.

4 participants