Introduce webp_uploads_prefer_smaller_image_file filter allowing to opt in to preferring the smaller image file
#287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…preferring the smaller image file regardless of MIME type.
felixarntz
added
[Type] Enhancement
mitogh
approved these changes
Apr 8, 2022
adamsilverstein
requested changes
Apr 13, 2022
Member
adamsilverstein
left a comment
adamsilverstein
left a comment
There was a problem hiding this comment.
left some small feedback points
adamsilverstein
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #286
Relevant technical choices
add_filtercall to the new function, but that would make it much less intuitive for developers, and they would need to use this "generic" filter, and remember the name of our "internal" function.webp_uploads_prefer_smaller_image_filefor the filter name for now.Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.