Skip to content

Remove experimental label from Dominant Color module and turn on by default for new installs #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
felixarntz merged 1 commit into from
Jul 12, 2022
Merged

Remove experimental label from Dominant Color module and turn on by default for new installs #425

felixarntz merged 1 commit into from
Jul 12, 2022

Conversation

@spacedmonkey
Copy link
Member

@spacedmonkey spacedmonkey commented Jul 12, 2022

Summary

Enable dominant color module by default and remove experiemently flag.

Fixes #402

Relevant technical choices

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@spacedmonkey spacedmonkey added [Type] Enhancement A suggestion for improvement of an existing feature [Focus] Images [Plugin] Image Placeholders Issues for the Image Placeholders plugin (formerly Dominant Color Images) labels Jul 12, 2022
@spacedmonkey spacedmonkey added this to the 1.3.0 milestone Jul 12, 2022
@spacedmonkey spacedmonkey requested a review from pbearne as a code owner July 12, 2022 11:18
@spacedmonkey spacedmonkey self-assigned this Jul 12, 2022
@mxbclang mxbclang changed the title Mark dominate color module as none experimental. Remove experimental label from dominant color module and turn on by default for new installs Jul 12, 2022
@felixarntz felixarntz changed the title Remove experimental label from dominant color module and turn on by default for new installs Remove experimental label from Dominant Color module and turn on by default for new installs Jul 12, 2022
@felixarntz felixarntz merged commit e96a6d9 into trunk Jul 12, 2022
@felixarntz felixarntz deleted the fix/color-always-on branch July 12, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pbearne pbearne pbearne approved these changes

@felixarntz felixarntz felixarntz approved these changes

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein

Assignees

@spacedmonkey spacedmonkey

Labels

[Plugin] Image Placeholders Issues for the Image Placeholders plugin (formerly Dominant Color Images) [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Milestone

1.3.0

Development

Successfully merging this pull request may close these issues.

Remove experimental label from dominant color module and turn on by default for new installs

4 participants

@spacedmonkey @pbearne @felixarntz