Skip to content

Fix an infinite loop in the WebP fallback mechanism #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
felixarntz merged 2 commits into from
Jul 15, 2022
Merged

Fix an infinite loop in the WebP fallback mechanism #433

felixarntz merged 2 commits into from
Jul 15, 2022

Conversation

@mukeshpanchal27
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 commented Jul 15, 2022 •
edited by felixarntz
Loading

Summary

Fixes #432

Relevant technical choices

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mukeshpanchal27 mukeshpanchal27 added [Type] Bug An existing feature is broken [Focus] Images labels Jul 15, 2022
@mukeshpanchal27 mukeshpanchal27 added this to the 1.3.0 milestone Jul 15, 2022
eugene-manuilov
eugene-manuilov requested changes Jul 15, 2022
View reviewed changes
@eugene-manuilov eugene-manuilov mentioned this pull request Jul 15, 2022
Closed
3 tasks
@eugene-manuilov eugene-manuilov added the [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) label Jul 15, 2022
jjgrainger
jjgrainger approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@jjgrainger jjgrainger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot on the issue and fix

@mukeshpanchal27 mukeshpanchal27 changed the title Fix infinite loading Fix an infinit loop in the fallback mechanism Jul 15, 2022
eugene-manuilov
eugene-manuilov approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@eugene-manuilov eugene-manuilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxbclang mxbclang changed the title Fix an infinit loop in the fallback mechanism Fix an infinite loop in the fallback mechanism Jul 15, 2022
mehulkaklotar
mehulkaklotar approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@mehulkaklotar mehulkaklotar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

felixarntz
felixarntz approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @mukeshpanchal27, and thank you for the quick fix!

This will need to go into the 1.3.0 release of course since it is critical, so I'll change the base branch accordingly.

@felixarntz felixarntz changed the base branch from trunk to release/1.3.0 July 15, 2022 15:38
@felixarntz felixarntz changed the title Fix an infinite loop in the fallback mechanism Fix an infinite loop in the WebP fallback mechanism Jul 15, 2022
@felixarntz felixarntz merged commit 4d5ae0e into release/1.3.0 Jul 15, 2022
@felixarntz felixarntz deleted the fix/432-infinite-loading branch July 15, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eugene-manuilov eugene-manuilov eugene-manuilov approved these changes

@jjgrainger jjgrainger jjgrainger approved these changes

@felixarntz felixarntz felixarntz approved these changes

@mitogh mitogh mitogh approved these changes

@mehulkaklotar mehulkaklotar mehulkaklotar approved these changes

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein adamsilverstein is a code owner

Assignees

No one assigned

Labels

[Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Bug An existing feature is broken

Projects

None yet

Milestone

1.3.0

Development

Successfully merging this pull request may close these issues.

Infinite loop in the fallback mechanism

7 participants

@mukeshpanchal27 @eugene-manuilov @jjgrainger @felixarntz @mitogh @mehulkaklotar