Add the original image's extension to the WebP file name to ensure it is unique #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukeshpanchal27
added
[Type] Bug
jjgrainger
requested changes
Jul 21, 2022
Contributor
jjgrainger
left a comment
jjgrainger
left a comment
There was a problem hiding this comment.
@mukeshpanchal27 all looks good, can we create a new test to explicitly test the extension suffix?
mukeshpanchal27
requested review from
adamsilverstein,
felixarntz and
mitogh
as code owners
felixarntz
approved these changes
Jul 26, 2022
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@mukeshpanchal27 Awesome, thank you!
felixarntz
removed
the
no milestone
felixarntz
changed the title
felixarntz
requested changes
Jul 26, 2022
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@mukeshpanchal27 The production logic already looks good, but I actually missed reviewing the test in more detail. As it currently is it is not a real unit test as it doesn't cover any of the changes you've made here. See my comment below.
Member
Author
|
Assign to @felixarntz for final review. |
felixarntz
approved these changes
Aug 8, 2022
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
Excellent work @mukeshpanchal27!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR I use the @adamsilverstein approach, which was used in the core patch WordPress/wordpress-develop@f41c83f
Fixes #395
Relevant technical choices
Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.