Skip to content

Fix opt-in checkbox for generating WebP and JPEG to also show on Multisite #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mehulkaklotar merged 5 commits into from
Oct 27, 2022
Merged

Fix opt-in checkbox for generating WebP and JPEG to also show on Multisite #565

mehulkaklotar merged 5 commits into from
Oct 27, 2022

Conversation

@mehulkaklotar
Copy link
Member

@mehulkaklotar mehulkaklotar commented Oct 20, 2022 •
edited
Loading

Summary

Fixes #560

Relevant technical choices

PR adds checkbox setting for WebP and JPEG in Settings > Media in the default section in the multisite for each site.

Screenshot 2022-10-20 at 6 58 21 PM

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mehulkaklotar mehulkaklotar added [Focus] Images [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) labels Oct 20, 2022
@mehulkaklotar mehulkaklotar added this to the 1.7.0 milestone Oct 20, 2022
@mehulkaklotar mehulkaklotar self-assigned this Oct 20, 2022
@mehulkaklotar mehulkaklotar added the [Type] Bug An existing feature is broken label Oct 20, 2022
@mehulkaklotar mehulkaklotar marked this pull request as ready for review October 20, 2022 12:40
mukeshpanchal27
mukeshpanchal27 reviewed Oct 20, 2022
View reviewed changes
felixarntz
felixarntz requested changes Oct 20, 2022
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mehulkaklotar Left a few points of feedback, this can be simplied quite a bit.

felixarntz
felixarntz approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mehulkaklotar, looks great!

@felixarntz felixarntz changed the title WebP upload configuration checkbox for multisite Fix opt-in checkbox for generating WebP and JPEG to also show on Multisite Oct 26, 2022
ankitrox
ankitrox approved these changes Oct 27, 2022
View reviewed changes
Copy link

@ankitrox ankitrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@mehulkaklotar mehulkaklotar merged commit e0aecd7 into trunk Oct 27, 2022
@mehulkaklotar mehulkaklotar deleted the fix/560-multimime-setting-multisite branch October 27, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 left review comments

@ankitrox ankitrox ankitrox approved these changes

@felixarntz felixarntz felixarntz approved these changes

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein

@mitogh mitogh Awaiting requested review from mitogh

@jjgrainger jjgrainger Awaiting requested review from jjgrainger

Assignees

@mehulkaklotar mehulkaklotar

Labels

[Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Bug An existing feature is broken

Projects

None yet

Milestone

1.7.0

Development

Successfully merging this pull request may close these issues.

WebP upload configuration checkbox not showing in Settings > Media for multisite

5 participants

@mehulkaklotar @ankitrox @felixarntz @mukeshpanchal27