-
Notifications
You must be signed in to change notification settings - Fork 139
Load the WP_Image_Editor_Imagick class if it doesn't exist #572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks @aristath for reporting. earlier today i face the same issue #566 (comment) |
|
@aristath @mukeshpanchal27 I think we should dig into the WP 6.1 release to identify why that is just failing now. The fix here is probably good to go, but IMO we should verify that it is indeed the appropriate solution and that we aren't missing something else it could be caused by. |
|
Some highlight of the changes that i made on this PR.
Props to @costdev for assisting and resolving this problem. PR now ready for review. |
costdev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just reviewed that the four additional changes I found to resolve the failures were applied. LGTM! 👍
modules/images/dominant-color/class-dominant-color-image-editor-gd.php
Outdated
Show resolved
Hide resolved
|
Thank you @mukeshpanchal27 and @costdev for the extra commits and the review! All tests now pass and this looks good! ❤️ |
mehulkaklotar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mukeshpanchal27 @costdev @aristath Thanks for fixing this. LGTM 🚀
Do we have any information on how the Image editor class isn't available in 6.1 and if we need to require it?
I haven't seen any fatalities in real-life, so I'm inclined to believe this was more related to the tests 👍 |
Summary
Recently I noticed that some tests are failing. I'm assuming (though not sure) that it's because of the WP 6.1 release, at least the timing lines-up.
Example: https://github.com/WordPress/performance/actions/runs/3374928930/jobs/5601071400
The problem seems to be the fact that the
WP_Image_Editor_Imagickclass is not loaded.Relevant technical choices
Added a
class_existscheck before the class in tests, and I'm just require_once the missing files.Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.