Skip to content

Conversation

@aristath
Copy link
Member

@aristath aristath commented Nov 2, 2022

Summary

Recently I noticed that some tests are failing. I'm assuming (though not sure) that it's because of the WP 6.1 release, at least the timing lines-up.
Example: https://github.com/WordPress/performance/actions/runs/3374928930/jobs/5601071400
The problem seems to be the fact that the WP_Image_Editor_Imagick class is not loaded.

Relevant technical choices

Added a class_exists check before the class in tests, and I'm just require_once the missing files.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@aristath aristath added [Type] Bug An existing feature is broken no milestone PRs that do not have a defined milestone for release Miscellaneous Issues not related to an existing focus area labels Nov 2, 2022
@mukeshpanchal27
Copy link
Member

Thanks @aristath for reporting. earlier today i face the same issue #566 (comment)

@felixarntz
Copy link
Member

@aristath @mukeshpanchal27 I think we should dig into the WP 6.1 release to identify why that is just failing now. The fix here is probably good to go, but IMO we should verify that it is indeed the appropriate solution and that we aren't missing something else it could be caused by.

@mukeshpanchal27
Copy link
Member

mukeshpanchal27 commented Nov 7, 2022

Some highlight of the changes that i made on this PR.

  • 9b48e3f - This adds new keys added to add_settings_section() in [54247].
  • 3ec7d40 - This replaces $this->factory and $this->factory() references with self::factory().
    See [54087]. $this->factory() is fine, but I used self::factory() as that's the change applied in the changeset mentioned.

Props to @costdev for assisting and resolving this problem. PR now ready for review.

Copy link
Contributor

@costdev costdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reviewed that the four additional changes I found to resolve the failures were applied. LGTM! 👍

@aristath
Copy link
Member Author

aristath commented Nov 7, 2022

Thank you @mukeshpanchal27 and @costdev for the extra commits and the review! All tests now pass and this looks good! ❤️

Copy link
Member

@mehulkaklotar mehulkaklotar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukeshpanchal27 @costdev @aristath Thanks for fixing this. LGTM 🚀

Do we have any information on how the Image editor class isn't available in 6.1 and if we need to require it?

@aristath aristath merged commit 03b13e5 into trunk Nov 7, 2022
@aristath aristath deleted the fix/missing-class-in-tests branch November 7, 2022 11:37
@aristath
Copy link
Member Author

aristath commented Nov 7, 2022

Do we have any information on how the Image editor class isn't available in 6.1 and if we need to require it?

I haven't seen any fatalities in real-life, so I'm inclined to believe this was more related to the tests 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no milestone PRs that do not have a defined milestone for release [Type] Bug An existing feature is broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants