Skip to content

Add wp-total metric to default Server-Timing metrics #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
felixarntz merged 1 commit into from
Mar 14, 2023
Merged

Add wp-total metric to default Server-Timing metrics #669

felixarntz merged 1 commit into from
Mar 14, 2023

Conversation

@felixarntz
Copy link
Member

@felixarntz felixarntz commented Mar 10, 2023 •
edited
Loading

Summary

Fixes #668

  • Note that in order to see the metric, you need to enable output buffering via the Server Timing API filter. See this Gist.
  • This data (also see WordPress Trac ticket) is an example where the code from this PR was already used.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@felixarntz felixarntz added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure labels Mar 10, 2023
@felixarntz felixarntz added this to the 2.1.0 milestone Mar 10, 2023
@felixarntz
Copy link
Member Author

felixarntz commented Mar 10, 2023

cc @oandregal

mukeshpanchal27
mukeshpanchal27 approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @felixarntz, LGTM!

joemcgill
joemcgill reviewed Mar 13, 2023
View reviewed changes
@felixarntz felixarntz merged commit a92b560 into trunk Mar 14, 2023
@felixarntz felixarntz deleted the add/server-timing-total-metric branch March 14, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joemcgill joemcgill joemcgill approved these changes

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 approved these changes

Assignees

No one assigned

Labels

Infrastructure Issues for the overall performance plugin infrastructure [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Milestone

2.1.0

Development

Successfully merging this pull request may close these issues.

Add Server-Timing metric for total load time

4 participants

@felixarntz @joemcgill @mukeshpanchal27