Skip to content

Conversation

@felixarntz
Copy link
Member

Summary

Related to #640, however can be merged independently.

Relevant technical choices

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@felixarntz felixarntz added [Type] Documentation Documentation to be added or enhanced [Focus] Images [Plugin] Image Placeholders Issues for the Image Placeholders plugin (formerly Dominant Color Images) labels Apr 6, 2023
@felixarntz felixarntz added this to the 2.2.0 milestone Apr 6, 2023
Copy link
Member

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only changing inline doc references, from what I can tell, but seems fine to me, assuming that is the intent.

@felixarntz
Copy link
Member Author

felixarntz commented Apr 6, 2023

@joemcgill Yes, the only relevant change outside of inline docs is the module name in the module header - which is still in an inline doc, but will be displayed to users, that is the most relevant change in this PR.

Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @felixarntz, The changes look good to me.

Do we need to update module slug images/dominant-color to images/dominant-color-images as we already implemented legacy_module_slugs feature in plugin

@felixarntz
Copy link
Member Author

@mukeshpanchal27 Thanks, that's a great idea! I'll implement a follow up PR.

@felixarntz felixarntz merged commit d40daab into trunk Apr 7, 2023
@felixarntz felixarntz deleted the rename/dominant-color-module branch April 7, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Plugin] Image Placeholders Issues for the Image Placeholders plugin (formerly Dominant Color Images) [Type] Documentation Documentation to be added or enhanced

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants