Skip to content

Conversation

@mukeshpanchal27
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 commented Apr 13, 2023

Summary

This PR mainly improves the manual workflow for standalone plugin releases.

  • Replaced the text input for the slug with a dropdown to select the specific modules so we don't get any human error if someone mistypes the slug.
  • Remove version input
  • How does the version work for automated and manual workflows?
    • Automated workflow: It will read the plugins.json file and based on json config it setup the standalone plugin.
    • Manual workflow: Based on the input slug the script will find the version for it, If the selected plugin slug is not present in plugins.json then trigger a failure and exit the workflow.

Also use test SVN credential so we can't release the plugin when doing testing.

I already open PR 10up/action-wordpress-plugin-deploy#122 that support the debug mode in deploy process. Once it will approve we can use DRY_RUN ENV variable for testing.

Fixes #703

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mukeshpanchal27 mukeshpanchal27 added Infrastructure Issues for the overall performance plugin infrastructure Needs Review labels Apr 13, 2023
@mukeshpanchal27 mukeshpanchal27 added no milestone PRs that do not have a defined milestone for release [Type] Enhancement A suggestion for improvement of an existing feature labels Apr 13, 2023
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukeshpanchal27 Logic-wise this looks great. I have two comments for things to improve though, particularly the hard-coded options are not desirable as they are duplicated from what should be in plugins.json instead.

@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review April 24, 2023 09:28
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukeshpanchal27 Thanks, this looks great now!

One additional comment for consideration, though not necessarily a blocker.

joemcgill
joemcgill previously approved these changes Apr 24, 2023
Copy link
Member

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working for me. 👍🏻

@felixarntz felixarntz added this to the 2.3.0 milestone May 8, 2023
@felixarntz felixarntz removed the no milestone PRs that do not have a defined milestone for release label May 8, 2023
@felixarntz
Copy link
Member

@mukeshpanchal27 Note that the DRY_RUN PR has now been merged upstream. So it would be great to incorporate that here.

@joemcgill joemcgill dismissed their stale review May 8, 2023 18:51

Dismissing my review until the debugging code is updated

@mukeshpanchal27
Copy link
Member Author

@mukeshpanchal27 Note that the DRY_RUN PR has now been merged upstream. So it would be great to incorporate that here.

@felixarntz The DRY_RUN PR has been merged into develop branch, not the stable branch, so we can't use it. If we have to use DRY_RUN then we have to use the develop branch, or we will use it once it is merged into the stable branch. cc. @joemcgill

@felixarntz
Copy link
Member

Thanks @mukeshpanchal27, in that case let's do that separately. Could you please open a tracking issue for us to set up DRY_RUN in the future once it becomes available in a stable version of the action?

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukeshpanchal27 Thanks, LGTM!

Just a reminder to update the below prior to merging.

@mukeshpanchal27
Copy link
Member Author

Thanks @mukeshpanchal27, in that case let's do that separately. Could you please open a tracking issue for us to set up DRY_RUN in the future once it becomes available in a stable version of the action?

@felixarntz, should we consider opening a separate issue to set up the DRY_RUN option? By doing so, the changes made will not be uploaded to SVN. This approach could be useful for testing the process before committing any actual changes. What are your thoughts on this?

@felixarntz
Copy link
Member

@mukeshpanchal27 Yes that's what I meant. We could somehow configure it I think so that for example in pull requests it is always set to have DRY_RUN enabled.

@felixarntz felixarntz mentioned this pull request May 10, 2023
3 tasks
Copy link
Member

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest updates look right to me. Thanks @mukeshpanchal27!

@joemcgill joemcgill merged commit 950c571 into trunk May 10, 2023
@joemcgill joemcgill deleted the fix/703-improve-manual-workflow branch May 10, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Infrastructure Issues for the overall performance plugin infrastructure [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve the UI for manual plugin releases

5 participants