-
Notifications
You must be signed in to change notification settings - Fork 139
Use dynamic version from plugins.json for manual workflow
#710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
felixarntz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mukeshpanchal27 Logic-wise this looks great. I have two comments for things to improve though, particularly the hard-coded options are not desirable as they are duplicated from what should be in plugins.json instead.
felixarntz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mukeshpanchal27 Thanks, this looks great now!
One additional comment for consideration, though not necessarily a blocker.
joemcgill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working for me. 👍🏻
|
@mukeshpanchal27 Note that the |
Dismissing my review until the debugging code is updated
@felixarntz The |
|
Thanks @mukeshpanchal27, in that case let's do that separately. Could you please open a tracking issue for us to set up |
felixarntz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mukeshpanchal27 Thanks, LGTM!
Just a reminder to update the below prior to merging.
@felixarntz, should we consider opening a separate issue to set up the |
|
@mukeshpanchal27 Yes that's what I meant. We could somehow configure it I think so that for example in pull requests it is always set to have |
joemcgill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest updates look right to me. Thanks @mukeshpanchal27!
Summary
This PR mainly improves the manual workflow for standalone plugin releases.
plugins.jsonfile and based on json config it setup the standalone plugin.plugins.jsonthen trigger a failure and exit the workflow.Also use test SVN credential so we can't release the plugin when doing testing.
I already open PR 10up/action-wordpress-plugin-deploy#122 that support the debug mode in deploy process. Once it will approve we can use
DRY_RUNENV variable for testing.Fixes #703
Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.