-
Notifications
You must be signed in to change notification settings - Fork 139
Implement migration prompt to migrate from SQLite module to standalone plugin due to removal in the following release #739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e SQLite module to migrate to the standalone plugin.
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @felixarntz. It looks good to me. I have some nitpick feedback and a few questions.
Sometimes, when we activate the SQLite Database Integration through step 2 and then return to the Performance Lab settings page, deactivating the module also deactivates the SQLite Database Integration plugin. is it intended behaviour?
I noticed that too, that's okay. It is due to the migration routine that the standalone plugin comes with. In the cases where the plugin takes care of that automatically, even better, one less step for the user. |
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @felixarntz, LGTM!
|
@aristath @joemcgill Would one of you be able to review this PR please? |
aristath
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Summary
Fixes #737
Relevant technical choices
modules/database/sqlitefiles).Screenshots
Admin notice awaiting step 1

Admin notice awaiting step 2

Admin notice awaiting step 3

Admin pointer

Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.