Fix SQLite module deactivation routine to make standalone plugin migration work correctly

[felixarntz]

Summary

Follow up to #739: When testing the migration flow from the SQLite module to the standalone plugin, @10upsimon noticed that the module is still active technically in case that the SQLite plugin gets deactivated after the migration. That is because the logic to deactivate the module was only applying on the SQLite database, but not the MySQL/MariaDB database.

This PR fixes that problem.

Relevant technical choices

• The issue was that the standalone plugin's routine to migrate from the PL module to it triggers the option change in a specific way that made the PL module's deactivation routine not run: At the point of the routine being called, no db.php drop-in file is present, since the SQLite plugin removes the PL drop-in before and only adds its own drop-in after.
• This PR therefore removes the file check from the main entry condition to the deactivation routine.
• Additionally, it also ensures the deactivation routine is run in case the SQLite plugin's constant is defined: Basically as long as either the PL module constant or SQLite plugin constant is defined, the WP site is using an SQLite database, so in that case the logic to modify the module settings in the other DB needs to run.

Testing steps

1. Activate the SQLite module.
2. Go to the PL settings page and spot the admin notice to migrate.
3. Install and activate the SQLite plugin. It should redirect you to its migration screen.
4. Click the primary CTA to migrate.
5. At this point you'll see a red notice that the drop-in is missing, even though the PL module is already deactivated in the SQLite database. This is odd, but unless we can find an easy fix, it's not critical: As soon as you refresh the page, it'll be gone.
6. Now the migration is complete. So go ahead and deactivate the SQLite plugin.
7. After a potential relogin to WordPress, you should notice that the PL module is still inactive, even though we're back to using the MySQL/MariaDB database.

The 7th point is the one that this PR fixes. Previously, the PL module would have been active at that point.

Checklist

• PR has either [Focus] or Infrastructure label.
• PR has a [Type] label.
• PR has a milestone or the no milestone label.

[aristath]

LGTM 👍

[mukeshpanchal27]

Thanks @felixarntz, Great work!

[10upsimon]

@felixarntz @mukeshpanchal27 I added this so that the PL SQLite module option can not be accidentally enabled by the end user once the standalone plugin is activated, thus preventing the following unnecessary fatal error:

Fatal error: Cannot redeclare w_install (previously declared in /var/www/html/w-content/plugins/sqlite-database-integration/wp-includes/sqlite/install-functions.php:138)in /var/www/html/wp-content/plugins/performance/modules/database/sqlite/wp-includes/sqlite/install-functions.php on line 122

[mukeshpanchal27]

Great catch!

[10upsimon]

I've added a fix to prevent activation of the sqlite module when the standalone plugin is enabled. Tested the rest and looks good to go for me.