build: dynamic link gflags/glog#3439
Closed
aceforeverd wants to merge 12 commits into4paradigm:mainfrom
Closed
Conversation
github-actions
bot
added
build
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3439 +/- ##
=============================================
- Coverage 75.72% 37.32% -38.41%
Complexity 414 414
=============================================
Files 703 178 -525
Lines 127271 10308 -116963
Branches 1206 1206
=============================================
- Hits 96371 3847 -92524
+ Misses 30659 6220 -24439
Partials 241 241 ☔ View full report in Codecov by Sentry. |
If BUILD_SHARED_LIBS=ON, gflags/glog/brpc all need to rebuild shared
Collaborator
Author
|
fixed by #3778 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thirdparty source improves:
fixes #3407