Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a backport of
https://github.com/TheThingsIndustries/lorawan-stack/pull/4841
https://github.com/TheThingsIndustries/lorawan-stack/pull/4843
Due to the recent change #7832 in the scheduler we see a memory increase in GS.
This fix tries to avoid to schedule an emission to far ahead in the future, holding a go routine to long time, causing a memory increase.
Also stops the timer in the Schedule late force case if the context is cancelled.
References: https://github.com/TheThingsIndustries/lorawan-stack-support/issues/1427
Changes
Testing
Steps
...
Results
Regressions
...
Notes for Reviewers
...
Checklist
README.mdfor the chosen target branch.CHANGELOG.md.CONTRIBUTING.md, there are no fixup commits left.