This repository was archived by the owner on Jan 26, 2022. It is now read-only.
Also allow stacking of negative margins in cover#339
Closed
erikjoling wants to merge 1 commit intoWordPress:trunkfrom
Closed
Also allow stacking of negative margins in cover#339erikjoling wants to merge 1 commit intoWordPress:trunkfrom
erikjoling wants to merge 1 commit intoWordPress:trunkfrom
Conversation
A fully aligned cover will have padding, just like the group-block.
Collaborator
|
Thanks, @erikjoling! This looks good:
@jffng and I aren't making any more bugfix commits in advance of the 5.9 code freeze on Monday, so we'll save this one and can push it in shortly after release. Thank you! |
Author
|
No problem at all. Thank you, also for the great theme :) |
Collaborator
|
Migrated to a PR in core, thanks again @erikjoling ! WordPress/wordpress-develop#2223 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A fully aligned block inside a fully aligned cover-block needs to have double negative margins, because it has double positive paddings. If this makes sense ^_^'
Just like the group block.
Testing Instructions