Skip to content

[AIRFLOW-4162] Support layout blocks in Slack operators#6402

Closed
bskim45 wants to merge 1 commit intoapache:masterfrom
bskim45:AIRFLOW-4162
Closed

[AIRFLOW-4162] Support layout blocks in Slack operators#6402
bskim45 wants to merge 1 commit intoapache:masterfrom
bskim45:AIRFLOW-4162

Conversation

@bskim45
Copy link
Copy Markdown
Contributor

@bskim45 bskim45 commented Oct 24, 2019

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

This PR adds support for Slack layout blocks in Slack operators: SlackAPIPostOperator, SlackWebhookOperator
https://api.slack.com/reference/block-kit/blocks

This PR also compatible with slack python sdk v1 which we are using, since slack SDK simply passes kwargs dict to the api client as a payload.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Updated corresponding operator tests

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@feluelle
Copy link
Copy Markdown
Member

feluelle commented Oct 26, 2019

Hey @bskim45, I am sorry, but would it be okay for you if we close this PR and add you as an co-author to #6418 ? It does basically the same and we already started to review the other one. :/

cc @mingrammer

@bskim45
Copy link
Copy Markdown
Contributor Author

bskim45 commented Oct 26, 2019

No problem @feluelle. I will close this PR.

@feluelle
Copy link
Copy Markdown
Member

I know, your PR was opened first.. :/

@mingrammer
Copy link
Copy Markdown
Contributor

mingrammer commented Oct 26, 2019

@bskim45 I'm sorry.. I didn't check there is already a PR for this issue.

@bskim45 bskim45 closed this Oct 26, 2019
@bskim45 bskim45 deleted the AIRFLOW-4162 branch October 30, 2019 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants