Auto-formatter to keep the same coding style

[mozga-intel]

Description

This pull-request contains changes associated with a coding style.
Contains:

1. src/operator/nn/mkldnn/
2. include/mxnet/ndarray.h
3. src/ndarray/ndarray.cc
4. src/operator/operator_common.h
5. src/operator/quantization/mkldnn/
6. src/operator/subgraph/mkldnn/
7. src/operator/tensor/amp_cast.cc
8. src/operator/tensor/cast_storage-inl.h
9. tests/cpp/include/test_mkldnn.h
10. tests/cpp/operator/mkldnn_operator_test

.clang-format file:

---
Language: Cpp
BasedOnStyle: Google
ColumnLimit: 100
#AlignAfterOpenBracket: AlwaysBreak
AlignConsecutiveAssignments: true
AlignConsecutiveDeclarations: false
AlignConsecutiveMacros: true
DerivePointerAlignment: false
SortIncludes: true
MaxEmptyLinesToKeep: 1
PointerAlignment: Left
AllowAllParametersOfDeclarationOnNextLine: false
AllowShortBlocksOnASingleLine: false
AllowShortCaseLabelsOnASingleLine: false
AllowShortFunctionsOnASingleLine: Empty
AllowShortIfStatementsOnASingleLine: false
AllowShortLoopsOnASingleLine: false
AlwaysBreakAfterReturnType: None
AlwaysBreakBeforeMultilineStrings: true
AlwaysBreakTemplateDeclarations: true
BinPackArguments: false
BinPackParameters: false

Checklist

Essentials

• PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
• Changes are complete (i.e. I finished coding on this PR)
• All changes have test coverage
• Code is well-documented

Changes

• Feature1, tests, (and when applicable, API doc)
• Feature2, tests, (and when applicable, API doc)

Comments

• If this change is a backward incompatible change, why must this change be made.
• Interesting edge cases to note here

[mxnet-bot]

Hey @mozga-intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

• To trigger all jobs: @mxnet-bot run ci [all]
• To trigger specific jobs: @mxnet-bot run ci [job1, job2]

---

CI supported jobs: [miscellaneous, centos-gpu, website, clang, unix-gpu, windows-gpu, sanity, unix-cpu, edge, windows-cpu, centos-cpu]

---

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

[mozga-intel]

@mxnet-bot run ci [unix-cpu, centos-cpu, unix-gpu]

[mxnet-bot]

Jenkins CI successfully triggered : [centos-cpu, unix-gpu, unix-cpu]

[mozga-intel]

@mxnet-bot run ci [unix-cpu, centos-cpu, unix-gpu]

[mxnet-bot]

Jenkins CI successfully triggered : [centos-cpu, unix-cpu, unix-gpu]

[mozga-intel]

@mxnet-bot run ci [centos-gpu, unix-cpu, unix-gpu]

[mxnet-bot]

Jenkins CI successfully triggered : [unix-cpu, unix-gpu, centos-gpu]

[mozga-intel]

@mxnet-bot run ci [windows-cpu , windows-gpu, unix-cpu]

[mxnet-bot]

Jenkins CI successfully triggered : [windows-gpu, unix-cpu, windows-cpu]

[szha]

Thanks for putting in the work for formatting the code for consistency. In order to keep the code nicely formatted, I think it would be worthwhile to automate the formatting and style checking. Do you have suggestions or plan in that regard?

[sfraczek]

LGTM

[mozga-intel]

@szha Thanks for a quick answer!

Proposition

Python

For a python, we can try to use the Flake8 tool. This tool might be used to perform additional formatting and semantic checking of code. For our machine, we can use hooks or pre-commit tools to run checker before commit. Please have a look at #20429 (proposition

C++

We can use the clang-format tool to perform additional formatting and semantic checking of code. Please have a look at #20433

Problem

I think that we need to run those scripts to get the same standard in the project.

Further consideration

Should these tools be run also on a CI?

[sfraczek]

In the last commit what are the changes something in .clang-format config?

[mozga-intel]

@sfraczek Yes, please have a look at the description: a few things were added such as BinPackArguments/Params...

[mozga-intel]

@mxnet-bot run ci [unix-gpu]

[mxnet-bot]

Jenkins CI successfully triggered : [unix-gpu]