[API Standardization]Standardize MXNet NumPy Statistical & Linalg Functions#20592

NathanYyc · 2021-09-17T14:26:25Z

Description

Part of API standardization

add element-wise functions
- add asin, asinh, acos, acosh, atan, atan2, atanh, bitwise_invert, pow & _ipow_
add manipulation functions
- add concat
change statistical functions
- std: change keyword "ddof" to "correction"
- var: change keyword "ddof" to "correction"
change linalg functions
- add vecdot
- eigvalsh: change keyword "UPLO" to "upper"
- eigh: change keyword "UPLO" to "upper"

Checklist

Essentials

PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
Changes are complete (i.e. I finished coding on this PR)
All changes have test coverage
Code is well-documented

Changes

Feature1, tests, (and when applicable, API doc)
Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

* fix website publish * update * remove .asf.yaml from version/master * force include .asf.yaml * include .htaccess * add .asf.yaml check in CI

mxnet-bot · 2021-09-17T14:26:29Z

Hey @NathanYyc , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

To trigger all jobs: @mxnet-bot run ci [all]
To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, windows-gpu, unix-gpu, edge, clang, centos-cpu, centos-gpu, miscellaneous, sanity, website, unix-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

NathanYyc · 2021-09-17T14:26:37Z

@barry-jin

python/mxnet/numpy/linalg.py

python/mxnet/numpy/multiarray.py

barry-jin · 2021-10-07T01:21:59Z

@mxnet-bot run ci [centos-gpu]

mxnet-bot · 2021-10-07T01:22:10Z

Jenkins CI successfully triggered : [centos-gpu]

NathanYyc · 2021-10-07T06:11:29Z

@mxnet-bot run ci [centos-gpu]

mxnet-bot · 2021-10-07T06:11:35Z

Jenkins CI successfully triggered : [centos-gpu]

python/mxnet/numpy/multiarray.py

Co-authored-by: Zhenghui Jin <69359374+barry-jin@users.noreply.github.com>

NathanYyc · 2021-10-11T08:20:33Z

@mxnet-bot run ci [unix-cpu]

mxnet-bot · 2021-10-11T08:20:37Z

Jenkins CI successfully triggered : [unix-cpu]

python/mxnet/numpy/linalg.py

NathanYyc · 2021-10-13T10:02:29Z

@mxnet-bot run ci [unix-gpu]

mxnet-bot · 2021-10-13T10:02:35Z

Jenkins CI successfully triggered : [unix-gpu]

NathanYyc · 2021-10-13T10:02:40Z

@mxnet-bot run ci [centos-gpu]

mxnet-bot · 2021-10-13T10:02:44Z

Jenkins CI successfully triggered : [centos-gpu]

barry-jin

Looks good. Thanks!

barry-jin and others added 6 commits September 16, 2021 17:48

[Website] Fix website publish (apache#20573)

da94ffb

* fix website publish * update * remove .asf.yaml from version/master * force include .asf.yaml * include .htaccess * add .asf.yaml check in CI

Merge remote-tracking branch 'origin/master'

d738884

Merge remote-tracking branch 'origin/master'

9e50049

Merge remote-tracking branch 'origin/master'

d572c71

change linalg & statical funcs

fb5a717

add vecdot

4b5fa73

NathanYyc requested a review from szha as a code owner September 17, 2021 14:26

mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Sep 17, 2021

barry-jin suggested changes Sep 17, 2021

View reviewed changes

barry-jin reviewed Sep 17, 2021

View reviewed changes

python/mxnet/numpy/multiarray.py Outdated Show resolved Hide resolved

barry-jin mentioned this pull request Sep 17, 2021

[Feature] MXNet NumPy Standard APIs Implementation Checklist #20579

Open

52 tasks

changes made

22e4ed5

mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Sep 22, 2021

changes made

3fdcc3c

mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Sep 22, 2021

changes made

8157c0a

mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Sep 24, 2021

changes made

5a0dea1

mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Sep 24, 2021

mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 7, 2021

barry-jin suggested changes Oct 8, 2021

View reviewed changes

python/mxnet/numpy/multiarray.py Outdated Show resolved Hide resolved

NathanYyc and others added 2 commits October 9, 2021 14:42

Update python/mxnet/numpy/multiarray.py

70c7e37

Co-authored-by: Zhenghui Jin <69359374+barry-jin@users.noreply.github.com>

merge conflicts

3c8eed3

mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Oct 11, 2021

solve typo

4bf327b

mseth10 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 11, 2021

barry-jin suggested changes Oct 11, 2021

View reviewed changes

python/mxnet/numpy/linalg.py Show resolved Hide resolved

python/mxnet/numpy/linalg.py Show resolved Hide resolved

NathanYyc added 2 commits October 12, 2021 08:25

add wrap_data_api_linalg_func in line 1335 & 1205

21c9fd3

add wrap_data_api_linalg_func in line 1335 & 1205

5eeb259

barry-jin approved these changes Oct 14, 2021

View reviewed changes

Conversation

NathanYyc commented Sep 17, 2021

Description

Checklist

Essentials

Changes

Comments

Uh oh!

mxnet-bot commented Sep 17, 2021

Uh oh!

NathanYyc commented Sep 17, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

barry-jin commented Oct 7, 2021

Uh oh!

mxnet-bot commented Oct 7, 2021

Uh oh!

NathanYyc commented Oct 7, 2021

Uh oh!

mxnet-bot commented Oct 7, 2021

Uh oh!

Uh oh!

NathanYyc commented Oct 11, 2021

Uh oh!

mxnet-bot commented Oct 11, 2021

Uh oh!

Uh oh!

Uh oh!

NathanYyc commented Oct 13, 2021

Uh oh!

mxnet-bot commented Oct 13, 2021

Uh oh!

NathanYyc commented Oct 13, 2021

Uh oh!

mxnet-bot commented Oct 13, 2021

Uh oh!

barry-jin left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants