[full-ci][tests-only] Add tests for db-convert occ command

[saw-jan]

Description

Related Issue

• Fixes add cli tests for occ db commands #39190

Motivation and Context

How Has This Been Tested?

• test environment:

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[ownclouders]

💥 Acceptance tests pipeline cliDbConversion-sqlite-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33261/3/1

[ownclouders]

💥 Acceptance tests pipeline cliDbConversion-sqlite-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33264/3/1

[ownclouders]

💥 Acceptance tests pipeline cliDbConversion-sqlite-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33341/3/1

[ownclouders]

💥 Acceptance tests pipeline cliDbConversion-sqlite-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33343/3/1

[ownclouders]

💥 Acceptance tests pipeline cliDbConversion-sqlite-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33348/3/1

[ownclouders]

💥 Acceptance tests pipeline cliDbConversion-sqlite-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33349/3/1

[saw-jan]

Currently blocked due to unknown error in afterScenario hooks

[kiranparajuli589]

I've initialized a state variable in featureContext to check if running for DB conversion. The variable state is set to true after successful DB conversion. but for the before scenario we don't know yet if the scenario is for DB conversion.

although multiple after hooks can be implemented even for specific tags, but the same is not true for a before. It can only be one and doesn't filter with tags.

Should we use some test environment variable, so that we can test some edge cases in this DB conversion feature?

cc @saw-jan @individual-it @phil-davis

[phil-davis]

https://drone.owncloud.com/owncloud/core/33955/4/14
Notice: Array to string conversion in /drone/src/tests/TestHelpers/SetupHelper.php line 920

I have a fix for that in bf96d4a

You can cherry-pick that commit into this branch. Then you should get the real Exception message logged.

[kiranparajuli589]

https://drone.owncloud.com/owncloud/core/33957/4/14

      ╳  Response is not valid XML after executing 'occ app:list --output json --no-ansi'. Is the testing app installed and enabled?

after a successful dB conversion, the testing app is disabled, maybe there is a reset.
but actually this was not true for me while trying locally.

cc @phil-davis

[phil-davis]

That is in an AfterScenario. For this special test, we only want to run a single scenario. So we can skip any AfterScenario actions. Basically, we throw-away the system-under-test after all the Scenario Then steps have finished.
(If someone runs this db-convert scenario locally, it is going to expect that their existing install starts with sqlite and will convert them to mysql, assuming they have a mysql database ready etc, so it is not the sort of test that anyone can easily run locally anyhow, so cleanup after the test is not important)

So add whatever code and/or tags are needed to avoid running stuff in AfterScenario that causes fails.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[kiranparajuli589]

That is in an AfterScenario. For this special test, we only want to run a single scenario. So we can skip any AfterScenario actions. Basically, we throw-away the system-under-test after all the Scenario Then steps have finished. (If someone runs this db-convert scenario locally, it is going to expect that their existing install starts with sqlite and will convert them to mysql, assuming they have a mysql database ready etc, so it is not the sort of test that anyone can easily run locally anyhow, so cleanup after the test is not important)

So add whatever code and/or tags are needed to avoid running stuff in AfterScenario that causes fails.

@phil-davis suggested changes have been implemented. Please review again.

[phil-davis]

LGTM. I will cherry-pick and squash this onto the "pending acceptance tests" PR #39514

[phil-davis]

cherry-picked to 5f98837