Skip to content

[tests-only] [full-ci]tests for occ command files_external#39511

Closed
sakshamgurung wants to merge 1 commit intomasterfrom
occ-test-files-external
Closed

[tests-only] [full-ci]tests for occ command files_external#39511
sakshamgurung wants to merge 1 commit intomasterfrom
occ-test-files-external

Conversation

@sakshamgurung
Copy link
Copy Markdown
Contributor

@sakshamgurung sakshamgurung commented Nov 19, 2021 •
edited
Loading

Description

Acceptance tests for occ command files_external and its variations.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@sakshamgurung sakshamgurung changed the title [tests-only] [full-ci]tests for occ command files-external [tests-only] [full-ci]tests for occ command files_external Nov 19, 2021
@sakshamgurung sakshamgurung self-assigned this Nov 19, 2021
@sakshamgurung sakshamgurung marked this pull request as draft November 19, 2021 10:00
@sakshamgurung sakshamgurung force-pushed the occ-test-files-external branch 12 times, most recently from 1a8ef8d to e2fe24f Compare November 26, 2021 05:40
@sakshamgurung
Copy link
Copy Markdown
Contributor Author

sakshamgurung commented Nov 29, 2021

I converted to draft because we do not want to merge acceptance test refactorings to master while the 10.9.0 release process is in progress.

@SwikritiT SwikritiT requested review from Talank and dpakach December 1, 2021 06:16
kiranparajuli589
kiranparajuli589 reviewed Dec 3, 2021
View reviewed changes
@sakshamgurung sakshamgurung force-pushed the occ-test-files-external branch 3 times, most recently from cfb1a26 to 7a5714e Compare December 3, 2021 08:11
kiranparajuli589
kiranparajuli589 reviewed Dec 3, 2021
View reviewed changes
@sakshamgurung sakshamgurung force-pushed the occ-test-files-external branch 3 times, most recently from 029d9ab to d6a60c7 Compare December 6, 2021 03:16
kiranparajuli589
kiranparajuli589 reviewed Dec 6, 2021
View reviewed changes
kiranparajuli589
kiranparajuli589 reviewed Dec 6, 2021
View reviewed changes
@sakshamgurung sakshamgurung force-pushed the occ-test-files-external branch 2 times, most recently from e0eacf4 to 242a21b Compare December 6, 2021 10:53
@sakshamgurung
Copy link
Copy Markdown
Contributor Author

sakshamgurung commented Dec 6, 2021

Some random fails. Please restart CI

@sakshamgurung sakshamgurung removed their assignment Dec 6, 2021
@phil-davis
Copy link
Copy Markdown
Contributor

phil-davis commented Dec 10, 2021

https://drone.owncloud.com/owncloud/core/33940/75/7
Error response from daemon: No such image: owncloudci/nodejs:14
"random" drone fail. I restarted CI.

@phil-davis
Copy link
Copy Markdown
Contributor

phil-davis commented Dec 10, 2021

https://drone.owncloud.com/owncloud/core/33993/121/18
The new tests ran and passed.
Now to review...

@kiranparajuli589 kiranparajuli589 self-assigned this Dec 10, 2021
@kiranparajuli589
Copy link
Copy Markdown
Contributor

kiranparajuli589 commented Dec 13, 2021

🔄 @phil-davis I updated the code with some changes (see latest commits). Please review again.

@kiranparajuli589 kiranparajuli589 marked this pull request as ready for review December 14, 2021 08:18
@kiranparajuli589 kiranparajuli589 removed their request for review December 14, 2021 10:26
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Dec 17, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

phil-davis
phil-davis approved these changes Dec 20, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will set to draft and cherry-pick to branch acceptance-test-changes-waiting-2021-11

@phil-davis phil-davis marked this pull request as draft December 20, 2021 06:50
@phil-davis phil-davis mentioned this pull request Dec 20, 2021
Closed
11 tasks
@phil-davis
Copy link
Copy Markdown
Contributor

phil-davis commented Dec 20, 2021

cherry-picked to #39514
I am leaving this draft for now. Hopefully that PR gets merged soon. Then we can close all these draft PRs.

@phil-davis phil-davis mentioned this pull request Dec 21, 2021
Merged
11 tasks
@phil-davis
Copy link
Copy Markdown
Contributor

phil-davis commented Dec 22, 2021

Merged to master in #39612

@phil-davis phil-davis closed this Dec 22, 2021
@phil-davis phil-davis deleted the occ-test-files-external branch December 22, 2021 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phil-davis phil-davis phil-davis approved these changes

@saw-jan saw-jan Awaiting requested review from saw-jan

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@swoichha swoichha Awaiting requested review from swoichha

@Talank Talank Awaiting requested review from Talank

@dpakach dpakach Awaiting requested review from dpakach

@individual-it individual-it Awaiting requested review from individual-it

+1 more reviewer

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kiranparajuli589 kiranparajuli589

Labels

QA:team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sakshamgurung @phil-davis @kiranparajuli589 @SwikritiT