[feature/alwaysreply] Add a permission to separate sending PMs and replying to them#492

imkingdavid · 2011-12-07T22:25:05Z

Adds a new permission (u_pm_reply) that can allow users to reply to Private Messages without being able to compose new PMs. The permission is ignored when u_sendpm is set to Yes, and is taken into account when u_sendpm is Never. In other words, a user will always be able to reply unless both u_sendpm AND u_pm_reply are Never.

imkingdavid · 2011-12-07T22:25:46Z

By the way, I don't know why those other three commits are there... I'm certain that I forked/branched the most recent develop revision. :/ Let me know if I need to change something.

nickvergessen · 2011-12-07T22:27:24Z

There should be a check whether the original pm was really send and it should than be only possible to reply to the sender, not any other additional users

imkingdavid · 2011-12-07T22:31:49Z

I see what you mean... I just changed senders within the reply and it still allowed it to send. I'll add a way for it to confirm that the reply is to only the original sender.

imkingdavid · 2011-12-07T23:46:07Z

Actually, there's a bug in that I just noticed, but I have no time to fix it atm. Will do later.

imkingdavid · 2011-12-08T02:44:58Z

Alright, this has been tested locally and works for me. Please feel free to test it and let me know if something needs to be changed or done differently.

p · 2011-12-08T04:27:40Z

You need to reset your develop branch to upstream develop and then rebase this branch on the resulting develop.

git checkout develop
git branch backup-develop
git reset --hard upstream/develop
git checkout ticket/10517
git branch backup-ticket/10517
git rebase -i develop
(make sure only this ticket's commits are listed)

p · 2011-12-08T04:30:50Z

http://area51.phpbb.com/phpBB/viewtopic.php?f=108&t=41767&p=231909#p231909

imkingdavid · 2011-12-23T00:56:21Z

phpBB/includes/ucp/ucp_pm_viewmessage.php

Note that if we're talking about always letting users reply, should we remove the permission for the first one (U_POST_REPLY_PM) and only require the permission to U_POST_REPLY_ALL? And in that case, we'd need some added logic to make sure that if they don't have to permission, they're actually replying to the original sender.

And on a non-related note, why is it POST_REPLY instead of SEND_REPLY or PM_REPLY?

nickvergessen · 2011-12-23T10:15:58Z

We should also ensure, that there is still a way to "silence" people.

imkingdavid · 2011-12-23T21:15:12Z

Well as the patch currently is, if they have no u_sendpm and no u_pm_reply, they cannot send messages, so they are effectively "silenced".

imkingdavid · 2011-12-26T01:26:22Z

Okay, so current progress is:
-Permission u_pm_reply is added.
-Logic is as such: If user has u_sendpm, ignore u_pm_reply (even set to NEVER). If user has u_pm_reply, still allow PM (even if u_sendpm is NEVER).

Do we want to make sure that if only u_pm_reply is enabled (no u_sendpm), the user is only replying to the original sender? I think for the most part this is done, other than that. Am I missing stuff?

Of course it still needs to be tested.

p · 2012-01-06T07:20:47Z

phpBB/develop/add_permissions.php

This should be reverted, ideally the commit where this is changed should be fixed.

travisbot · 2012-05-09T22:07:09Z

This pull request fails (merged e4e0f092 into 1d0607c).

travisbot · 2012-05-09T22:08:47Z

This pull request fails (merged 3e8afd3b into 1d0607c).

travisbot · 2012-05-09T22:09:51Z

This pull request fails (merged c1fd31fb into 1d0607c).

travisbot · 2012-05-09T23:26:31Z

This pull request fails (merged dd3d0fcf into 1d0607c).

p · 2012-05-09T23:28:06Z

phpBB/develop/add_permissions.php

(19:22:58) nx-: that file had an a9 which is i'm assuming iso-8859-1 but not utf-8
(19:24:25) nx-: c2 a9 is valid utf-8
(19:24:31) nx-: github must be misrendering it
(19:24:56) nx-: it renders the new version correctly
(19:25:16) nx-: obviously it is impossible to render 8859-1 and utf8 mix correctly
(19:25:49) nx-: i would suggest going through all existing files grepping for a9 not preceded by c2
(19:25:51) nx-: and fixing them

travisbot · 2012-05-10T21:26:01Z

This pull request fails (merged 5d2b841e into 61eb015).

imkingdavid · 2012-08-22T11:15:45Z

I believe that this is done, but I haven't looked at it in a while. If someone doesn't mind reviewing it I think it's ready for a merge.

p · 2012-12-07T20:56:08Z

I am not seeing any database updater changes. The rest looks ok.

imkingdavid · 2012-12-12T15:38:26Z

@p Database updater changes have been added.

imkingdavid · 2012-12-13T01:06:48Z

This should wait for #985 as that PR introduces a new function for adding permissions that this PR can then use.

p · 2012-12-13T02:16:25Z

Merged #985.

PHPBB3-10517

…ries PHPBB3-10517

PHPBB3-10517

imkingdavid · 2012-12-13T20:41:44Z

@p i've implemented the _add_permission() function in this PR, so it should be ready for a merge.

p · 2012-12-15T05:34:52Z

Does not appear to actually work.

Database updated a QI installed board.
Gave admin never for sendpm
Sent admin a pm
Admin sees reply link
Following it produces: We are sorry, but you are not authorised to use this feature. You may have just registered here and may need to participate more to be able to use this feature.

Investigate S_NO_AUTH_SEND_MESSAGE.

p · 2012-12-15T18:25:54Z

Also please use italicized styling like acl_a_user does.

EXreaction · 2013-01-11T23:26:47Z

phpBB/language/en/acp/permissions_phpbb.php

I would suggest:
Can send private messages (implies send and reply)
Can reply to private messages

EXreaction · 2013-01-11T23:29:45Z

Do we want to make sure that if only u_pm_reply is enabled (no u_sendpm), the user is only replying to the original sender?

Yes please.

bantu · 2013-01-11T23:43:54Z

phpBB/includes/ucp/ucp_pm_compose.php

Should at least apply De Morgan here and make it else if (!$auth->acl_get('u_pm_reply') && !$auth->acl_get('u_sendpm'))

p · 2013-04-30T03:08:52Z

No test coverage based on my comment about this feature not working?

EXreaction · 2013-07-06T16:18:18Z

@imkingdavid bump

imkingdavid · 2013-07-07T03:34:52Z

I'll close this for now. Someone else is welcome to take over if they want before I come back to it.

imkingdavid reviewed Dec 23, 2011
View reviewed changes

p reviewed Jan 6, 2012
View reviewed changes

phpBB/develop/add_permissions.php Outdated

Copy link
Copy Markdown

Contributor

p Jan 6, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be reverted, ideally the commit where this is changed should be fixed.

p reviewed May 9, 2012
View reviewed changes

imkingdavid mentioned this pull request Dec 13, 2012

[ticket/11088] Move style, extension and language pack management to Customise tab #985

Merged

imkingdavid added 3 commits December 13, 2012 15:39

[feature/alwaysreply] Added permission u_pm_reply

61b27d3

PHPBB3-10517

[feature/alwaysreply] Implemented u_pm_reply permission, language ent…

a61b2c6

…ries PHPBB3-10517

[feature/alwaysreply] Disallow reply when u_pm_reply is No

3b39ab9

PHPBB3-10517

imkingdavid added 6 commits December 13, 2012 15:39

[feature/alwaysreply] Removed redundant logic

8359322

PHPBB3-10517

[feature/alwaysreply] Reverted language of u_sendpm, altered u_pm_reply

54c4f14

PHPBB3-10517

[feature/alwaysreply] Logic: reply works with u_sendpm or u_pm_reply

769cd37

PHPBB3-10517

[feature/alwaysreply] Add missing language string

2c5f0a4

PHPBB3-10517

[feature/alwaysreply] Add u_pm_reply permission during update

a2bb529

PHPBB3-10517

[feature/alwaysreply] Use _add_permission function

795381f

PHPBB3-10517

EXreaction reviewed Jan 11, 2013
View reviewed changes

bantu reviewed Jan 11, 2013
View reviewed changes

imkingdavid closed this Jul 7, 2013

Uh oh!

Conversation

imkingdavid commented Dec 7, 2011

Uh oh!

imkingdavid commented Dec 7, 2011

Uh oh!

nickvergessen commented Dec 7, 2011

Uh oh!

imkingdavid commented Dec 7, 2011

Uh oh!

imkingdavid commented Dec 7, 2011

Uh oh!

imkingdavid commented Dec 8, 2011

Uh oh!

p commented Dec 8, 2011

Uh oh!

p commented Dec 8, 2011

Uh oh!

imkingdavid Dec 23, 2011

Choose a reason for hiding this comment

Uh oh!

nickvergessen commented Dec 23, 2011

Uh oh!

imkingdavid commented Dec 23, 2011

Uh oh!

imkingdavid commented Dec 26, 2011

Uh oh!

p Jan 6, 2012

Choose a reason for hiding this comment

Uh oh!

travisbot commented May 9, 2012

Uh oh!

travisbot commented May 9, 2012

Uh oh!

travisbot commented May 9, 2012

Uh oh!

travisbot commented May 9, 2012

Uh oh!

p May 9, 2012

Choose a reason for hiding this comment

Uh oh!

travisbot commented May 10, 2012

Uh oh!

imkingdavid commented Aug 22, 2012

Uh oh!

p commented Dec 7, 2012

Uh oh!

imkingdavid commented Dec 12, 2012

Uh oh!

imkingdavid commented Dec 13, 2012

Uh oh!

p commented Dec 13, 2012

Uh oh!

imkingdavid commented Dec 13, 2012

Uh oh!

p commented Dec 15, 2012

Uh oh!

p commented Dec 15, 2012

Uh oh!

EXreaction Jan 11, 2013

Choose a reason for hiding this comment

Uh oh!

EXreaction commented Jan 11, 2013

Uh oh!

bantu Jan 11, 2013

Choose a reason for hiding this comment

Uh oh!

p commented Apr 30, 2013

Uh oh!

EXreaction commented Jul 6, 2013

Uh oh!

imkingdavid commented Jul 7, 2013

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!