Skip to content

bpo-40520: Port the declartions in pydebug.h to initconfig.h#19930

Closed
shihai1991 wants to merge 1 commit intopython:masterfrom
shihai1991:bpo_40520
Closed

bpo-40520: Port the declartions in pydebug.h to initconfig.h#19930
shihai1991 wants to merge 1 commit intopython:masterfrom
shihai1991:bpo_40520

Conversation

@shihai1991
Copy link
Member

@shihai1991 shihai1991 commented May 5, 2020 •
edited by bedevere-bot
Loading

@shihai1991 shihai1991 requested a review from a team as a code owner May 5, 2020 14:48
vstinner
vstinner requested changes May 5, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that this change is needed. I'm fine with keeping pydebug.h. A C extension may include directly "pydebug.h". Just leave it unchanged.

@bedevere-bot
Copy link

bedevere-bot commented May 5, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@shihai1991
Copy link
Member Author

shihai1991 commented May 5, 2020

I don't think that this change is needed. I'm fine with keeping pydebug.h. A C extension may include directly "pydebug.h". Just leave it unchanged.

Copy that. Thanks for your explanation, I close this PR now.

@shihai1991 shihai1991 closed this May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner requested changes

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shihai1991 @bedevere-bot @vstinner @the-knights-who-say-ni