Added get_unchecked and get_unchecked_mut to OnceLock and LazyLock#138914
Open
HomelikeBrick42 wants to merge 2 commits intorust-lang:mainfrom
Open
Added get_unchecked and get_unchecked_mut to OnceLock and LazyLock#138914HomelikeBrick42 wants to merge 2 commits intorust-lang:mainfrom
get_unchecked and get_unchecked_mut to OnceLock and LazyLock#138914HomelikeBrick42 wants to merge 2 commits intorust-lang:mainfrom
Conversation
Collaborator
rustbot
added
S-waiting-on-review
Contributor
Author
|
i dont know if the issue number can just point to a pull request? do i have to make a separate issue? |
Member
|
This should go through an ACP first to gauge team interest. |
jhpratt
added
needs-acp
Dylan-DPC
added
the
S-waiting-on-author
Member
|
@HomelikeBrick42 Do you intend to open an ACP for this? |
Contributor
Author
|
i was going to but then i forgot about it, ill make one now |
Contributor
Author
|
i have made an ACP rust-lang/libs-team#654 |
jhpratt
added
S-waiting-on-ACP
jhpratt
added
S-waiting-on-author
Member
|
With the ACP now accepted, we just need a tracking issue and the issue number updated in the PR. |
Collaborator
|
☔ The latest upstream changes (presumably #147928) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
Hi @HomelikeBrick42, ping from triage team. Would you still like to move forward with this proposal? |
Contributor
Author
|
@SpriteOvO yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds methods for avoiding the atomic checks when accessing the value in a
OnceLockorLazyLock