Update comments in do_exec and add assertion for fd flag#147656
Open
chenyukang wants to merge 1 commit intorust-lang:mainfrom
Open
Update comments in do_exec and add assertion for fd flag#147656chenyukang wants to merge 1 commit intorust-lang:mainfrom
chenyukang wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @ibraheemdev rustbot has assigned @ibraheemdev. Use |
chenyukang
commented
Oct 14, 2025
Member
|
See #147624 (comment) for why I don't think this is necessary. |
tgross35
reviewed
Oct 16, 2025
Comment on lines
+290
to
+293
| // SAFETY: Dropping `stdio` (ChildPipes) is safe here since ChildPipes | ||
| // does not involve heap memory allocations | ||
| debug_assert!(size_of::<ChildPipes>() <= 24); | ||
| drop(stdio); |
Contributor
There was a problem hiding this comment.
Agreed with joboet that we shouldn't need this. If anything, you could do a debug_assert with F_GETFL that ensures F_CLOEXEC is set.
Member
Author
There was a problem hiding this comment.
yeah, I changed the PR to update outdated comments and add debug_assertion.
chenyukang
force-pushed
the
yukang-fix-exec-file-issue
branch
from
3f065a5 to
30b8146
Compare
chenyukang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #147624