wasm32-unknown-unknown: Make exnref eh the default#151707
Draft
hoodmane wants to merge 1 commit intorust-lang:mainfrom
Draft
wasm32-unknown-unknown: Make exnref eh the default#151707hoodmane wants to merge 1 commit intorust-lang:mainfrom
hoodmane wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
hoodmane
force-pushed
the
wasm32-uknown-unknown-exnref-default
branch
from
9f1206b to
c997379
Compare
|
I believe the suggestion for this is to make it the default for all targets, not just wasm32-unknown-unknown, ensuring that the remaining stability questions have been worked through comprehensively. For emscripten specifically, we could consider a different default if that is desired initially. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far it seems that adding
-Cllvm-args=-wasm-use-legacy-eh=truedoes not override this. We certainly shouldn't merge it until we have a way to toggle it back.