Open
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Mark-Simulacrum
requested changes
Mar 22, 2026
| //! a single-threaded way—they do not implement [`Sync`]. (If you need to do aliasing and | ||
| //! mutation among multiple threads, [`Mutex<T>`], [`RwLock<T>`], [`OnceLock<T>`] or [`atomic`] | ||
| //! types are the correct data structures to do so). | ||
| //! presence of aliasing. [`Cell<T>`], [`RefCell<T>`], [`OnceCell<T>`], and [`LazyCell<T, F>`] |
Member
There was a problem hiding this comment.
This is not the only such list (e.g., just below it is repeated again). I think right now all the cell types in std::cell fit this definition, and they're listed out with details below. My guess is that more may be added in the future. I think we should remove the attempt to list all types and instead reference the list below and in std::sync for the multithread case.
Can you try to reword to fit that?
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
LazyCell<T, F>to the list in the documentation ofCell