fix spurious test failure in metadata_access_times#153871
Open
mattiapitossi wants to merge 2 commits intorust-lang:mainfrom
Open
fix spurious test failure in metadata_access_times#153871mattiapitossi wants to merge 2 commits intorust-lang:mainfrom
metadata_access_times#153871mattiapitossi wants to merge 2 commits intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
library/std/src/fs/tests.rs
Outdated
| // Not always available | ||
| match (a.created(), b.created()) { | ||
| (Ok(t1), Ok(t2)) => assert!(t1 <= t2), | ||
| (Ok(_), Ok(_)) => {} |
Member
There was a problem hiding this comment.
I think it would make sense to keep the check, instead querying the system time and if it has moved back skip the test? (Running it a few times could also work but moving back should hopefully be quite rare.)
Mark-Simulacrum
added
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #148408
The metadata_access_times test checks if the creation of a file occurs before another file, this check happens only on Linux. While on Win and Macos we check only that the created metadata is available. Given that the SystemTime is non monotonic as Instant this test could result in failures when the system clock changes.
Sorry If I missed something, this is my first contribution.