Reorganisation of UI Tests#153962

rishi-techo-14 · 2026-03-16T16:04:19Z

Reorganize 11 tests in tests/ui/issues to appropriate subdirectories

This PR reorganizes tests in tests/ui/issues folder following the workflow suggested in the comment on #149411

Workflow:

Move 11 tests to appropriate directories (such as pattern, typeck, traits, borrowck, closures).
Rename each test in {reason}-issue-xxxx.rs format along with its corresponding .stderr file
Add issue links and short description about what the test checks

All tests pass tidy locally using

python x.py test tidy

rustbot · 2026-03-16T16:04:30Z

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 69 candidates
Random selection from 15 candidates

rishi-techo-14 · 2026-03-16T16:07:49Z

@rustbot r? @Kivooeo

Kivooeo

Remove the word "issue" from all test names and remove the issue numbers from those tests whose names are descriptive enough.

View changes since this review

Kivooeo · 2026-03-16T16:27:46Z

Also, remove the comments describing what the test is doing if the test is simple enough. However, keep an issue link and add a new line between your comment and the test.

Here's an example of what the test could look like: #152732.

cyrgani · 2026-03-16T23:05:30Z

tests/ui/typeck/duplicate-method-definitions-in-impl.rs

@@ -1,3 +1,5 @@
+// https://github.com/rust-lang/rust/issues/4265


This should not be moved to ui/traits, there are no traits involved at all.

Maybe put this in ui/methods instead?

Kivooeo · 2026-03-17T19:42:29Z

@rustbot author

rustbot · 2026-03-17T19:42:34Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

rishi-techo-14 · 2026-03-20T15:52:07Z

@rustbot ready
I've finished the reorganization and cleanup. All 11 tests are successfully named and relocated, and tidy passes locally.
NOTE: My Windows PC is crashing(0xc0000005) during the full build when i try to run "python x.py test tests/ui --bless ", so I couldn't bless the .stderr files. I've pushed the changes so they can be blessed through CI.

Kivooeo · 2026-03-20T15:58:02Z

've pushed the changes so they can be blessed through CI.

What do you mean by that

rishi-techo-14 · 2026-03-20T16:30:44Z

I was referring to the @rustbot bless command.
I am unable to to run python x.py test tests/ui --bless on my local machine because the build consistently fails with a STATUS_ACCESS_VIOLATION (0xc0000005) while compiling library/core, which prevents me from running python x.py test tests/ui --bless myself.
So, since I can't generate the updated .stderr files locally due to the environment crash, I was hoping a maintainer could trigger @rustbot bless once the PR passes tidy, or kindly guide me if there is a way to trigger the CI-bless myself.

Kivooeo · 2026-03-20T17:02:52Z

there is no CI-bless command or any way to do so... I think the best way you can do is run ./x test ui, then check what tests are failing and do ./x test path/to/test --bless by one on each failed test

Kivooeo · 2026-03-20T17:15:20Z

Oh, I see. You can't run the compile test because you can't build the library. In that case, I could try pushing these changes directly into your branch.

I'm not sure how feasible this is for GSoC, but we could give you access to our cloud computing if you were chosen for the project.

rishi-techo-14 · 2026-03-28T03:43:09Z

Hey @Kivooeo and @cyrgani! I rectified the issues I was facing in my local Windows (regarding the STATUS_ACCESS_VIOLATION issues ) by performing a full Stage 1 Bootstrap and then blessing the 7 folders in tests/ui.
Since all the checks are passed, I would like to present to a final review of this PR, whenever you could have a moment. Thank you.

rishi-techo-14 · 2026-03-29T10:53:50Z

@rustbot ready

tests/ui/borrowck/cannot-move-out-of-borrowed-field.rs

rishi-techo-14 · 2026-03-29T14:48:47Z

@rustbot ready

Kivooeo · 2026-04-08T12:12:50Z

can you squash the commits the way i explained in comment below, it's so hard to review at current state

this comment should be clear enough #149411 (comment) to make it correct, if not - please, ask questions

Kivooeo · 2026-04-08T12:13:27Z

@rustbot author

rustbot · 2026-04-08T16:44:02Z

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

-Rename tests for clarity. -Add issue links and descriptions. -Clean up formatting and comments.

rustbot · 2026-04-08T16:56:56Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

rishi-techo-14 · 2026-04-08T17:02:24Z

Thanks for pointing this out. I've squashed the commits the way said in comment on #149411.

rishi-techo-14 · 2026-04-09T01:14:25Z

@rustbot ready

Kivooeo · 2026-04-09T02:30:06Z

move and rename in first commit and everything that touches its content in second (comment, bless, fmt, etc.)

cyrgani · 2026-04-09T18:59:59Z

tests/ui/typeck/tuple-struct-field-constructor-error.rs

@@ -1,3 +1,5 @@
+// https://github.com/rust-lang/rust/issues/4736


View changes since the review

I don't think this belongs in ui/typeck. ui/structs seems more appropriate.

cyrgani · 2026-04-09T19:01:20Z

tests/ui/typeck/duplicate-method-definitions-in-impl.rs

@@ -1,3 +1,5 @@
+// https://github.com/rust-lang/rust/issues/4265


Maybe put this in ui/methods instead?

rustbot assigned JohnTitor Mar 16, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 16, 2026

rustbot assigned Kivooeo and unassigned JohnTitor Mar 16, 2026

Kivooeo reviewed Mar 16, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

cyrgani reviewed Mar 16, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 17, 2026

This comment has been minimized.

Sign in to view

rishi-techo-14 force-pushed the ui-tests-reorg-v2 branch from f0c2376 to 24c516f Compare March 20, 2026 15:41

This comment has been minimized.

Sign in to view

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 20, 2026

This comment has been minimized.

Sign in to view

rishi-techo-14 force-pushed the ui-tests-reorg-v2 branch from 24c516f to 42250a2 Compare March 27, 2026 17:26

cyrgani reviewed Mar 29, 2026

View reviewed changes

tests/ui/borrowck/cannot-move-out-of-borrowed-field.rs Show resolved Hide resolved

rishi-techo-14 force-pushed the ui-tests-reorg-v2 branch from 42250a2 to 1a8e127 Compare March 29, 2026 13:16

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 8, 2026

rishi-techo-14 force-pushed the ui-tests-reorg-v2 branch from 1a8e127 to 7158f89 Compare April 8, 2026 16:43

This comment has been minimized.

Sign in to view

rishi-techo-14 added 2 commits April 8, 2026 22:21

Move several tests from tests/ui/issues to appropriate subdirectories

8a1d2f7

Reorganize UI tests after migration

95b0165

-Rename tests for clarity. -Add issue links and descriptions. -Clean up formatting and comments.

rishi-techo-14 force-pushed the ui-tests-reorg-v2 branch from 7158f89 to 95b0165 Compare April 8, 2026 16:56

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 9, 2026

cyrgani requested changes Apr 9, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2026

		@@ -1,3 +1,5 @@
		// https://github.com/rust-lang/rust/issues/4265

Uh oh!

Conversation

rishi-techo-14 commented Mar 16, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reorganize 11 tests in tests/ui/issues to appropriate subdirectories

Workflow:

Uh oh!

rustbot commented Mar 16, 2026

Uh oh!

rishi-techo-14 commented Mar 16, 2026

Uh oh!

Kivooeo left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kivooeo commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

cyrgani Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

cyrgani Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Kivooeo commented Mar 17, 2026

Uh oh!

rustbot commented Mar 17, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rishi-techo-14 commented Mar 20, 2026

Uh oh!

Kivooeo commented Mar 20, 2026

Uh oh!

This comment has been minimized.

rishi-techo-14 commented Mar 20, 2026

Uh oh!

Kivooeo commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kivooeo commented Mar 20, 2026

Uh oh!

rishi-techo-14 commented Mar 28, 2026

Uh oh!

rishi-techo-14 commented Mar 29, 2026

Uh oh!

Uh oh!

rishi-techo-14 commented Mar 29, 2026

Uh oh!

Kivooeo commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kivooeo commented Apr 8, 2026

Uh oh!

rustbot commented Apr 8, 2026

Uh oh!

This comment has been minimized.

rustbot commented Apr 8, 2026

Uh oh!

rishi-techo-14 commented Apr 8, 2026

Uh oh!

rishi-techo-14 commented Apr 9, 2026

Uh oh!

Kivooeo commented Apr 9, 2026

Uh oh!

cyrgani Apr 9, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cyrgani Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

rishi-techo-14 commented Mar 16, 2026 •

edited by rustbot

Loading

Kivooeo left a comment •

edited by rustbot

Loading

Kivooeo commented Mar 16, 2026 •

edited

Loading

Kivooeo commented Mar 20, 2026 •

edited

Loading

Kivooeo commented Apr 8, 2026 •

edited

Loading

cyrgani Apr 9, 2026 •

edited by rustbot

Loading