Fix deref field pattern suggestions and improve error messages#154543
Open
chenyukang wants to merge 1 commit intorust-lang:mainfrom
Open
Fix deref field pattern suggestions and improve error messages#154543chenyukang wants to merge 1 commit intorust-lang:mainfrom
chenyukang wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
r? @fmease rustbot has assigned @fmease. Use Why was this reviewer chosen?The reviewer was selected based on:
|
chenyukang
commented
Mar 29, 2026
| | | ||
| LL | match &arg.field { | ||
| | + | ||
| LL | Some(ref s) => s.push('a'), |
Member
Author
There was a problem hiding this comment.
it's perfect if we suggest ref mut here, but current diagnostic is better than &arg.field, because it's at least a right direction, since user will get this if apply ref fix here:
help: consider changing this to be a mutable reference
|
7 | Some(ref mut s) => s.push('a'), //~ ERROR cannot borrow `s` as mutable
| +++
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #146995