Move std::io::ErrorKind to core::io#154654
Open
bushrat011899 wants to merge 6 commits intorust-lang:mainfrom
Open
Move std::io::ErrorKind to core::io#154654bushrat011899 wants to merge 6 commits intorust-lang:mainfrom
std::io::ErrorKind to core::io#154654bushrat011899 wants to merge 6 commits intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
added
T-rustdoc
This comment has been minimized.
This comment has been minimized.
bushrat011899
force-pushed
the
core_io_error_kind
branch
from
6acf3fc to
0c00e70
Compare
This comment has been minimized.
This comment has been minimized.
bushrat011899
force-pushed
the
core_io_error_kind
branch
from
0c00e70 to
a87a02a
Compare
This comment has been minimized.
This comment has been minimized.
bushrat011899
force-pushed
the
core_io_error_kind
branch
2 times, most recently
from
8faa574 to
0ef55d6
Compare
This comment has been minimized.
This comment has been minimized.
bushrat011899
force-pushed
the
core_io_error_kind
branch
from
0ef55d6 to
3e16c8b
Compare
This comment has been minimized.
This comment has been minimized.
bushrat011899
force-pushed
the
core_io_error_kind
branch
from
3e16c8b to
56dfe2e
Compare
This comment has been minimized.
This comment has been minimized.
bushrat011899
force-pushed
the
core_io_error_kind
branch
from
56dfe2e to
aa24135
Compare
This comment has been minimized.
This comment has been minimized.
bushrat011899
force-pushed
the
core_io_error_kind
branch
from
aa24135 to
f25b166
Compare
This comment has been minimized.
This comment has been minimized.
bushrat011899
force-pushed
the
core_io_error_kind
branch
from
f25b166 to
94753ea
Compare
Certain links will not be valid when moved into `core::io`
* Checking exhaustion will no longer be possible for `repr_bitpacked`. We can rely on `non_exhaustive_omitted_patterns` to maintain the exhaustive property for us instead. * `ErrorKind::as_str` is private, but it's only usage is trivially replaced with `Display::fmt` * The features io_error_inprogress, io_error_more, and io_error_uncategorized will all need to be enabled
* Update `rustdoc-html` tests for the new path * Add `core_io_error_kind` feature to control stability * Re-export `core::io::ErrorKind` in `std::io::error`
bushrat011899
force-pushed
the
core_io_error_kind
branch
from
94753ea to
b0ce24e
Compare
Contributor
It may be controversial, but it has been accepted in principle by libs-teams, so it should be fine. |
Author
I hope so! I really want your PR to land. Regardless of whether it does, this is a good follow-up to go further at basically no cost. |
Contributor
|
looks good to me |
Mark-Simulacrum
requested changes
Apr 4, 2026
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Remade as an associated function that is hidden and perma-unstable
More descriptive
rustbot
added
O-unix
This comment has been minimized.
This comment has been minimized.
bushrat011899
force-pushed
the
core_io_error_kind
branch
from
c690493 to
16624a6
Compare
This comment has been minimized.
This comment has been minimized.
Both `io_error_kind_in_core` and `core_io_borrowed_buf` require an unstable `core::io` module, but there is no way to make a module unstable and activated by `any(...)`
bushrat011899
force-pushed
the
core_io_error_kind
branch
from
16624a6 to
70e9804
Compare
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View all comments
ACP: rust-lang/libs-team#755
Tracking issue: #154046
Related: #152918
Description
I consider #154046 to be really important for
no_std, but I'm concerned #152918 might be too controversial. As an alternative, I'd like to propose starting small withErrorKind, since it can be moved somewhat trivially. It has no dependencies on functionality instd, no platform specific behaviour, and could provide an excellent bridging point forno_stdIO libraries.Since
std::io::ErrorimplementsFrom<ErrorKind>, libraries could write functions which returnResult<T, core::io::ErrorKind>, and therefore be usable instd-using libraries with the?operator. For that reason, I'd consider this to be a worthwhile change even if the rest ofstd::iocouldn't be moved tocore/alloc, and entirely compatible with any efforts to make such a change in the future.Notes