distinguish "expected a single argument" and "expected an argument" on attribute parsing#154827
Open
scrabsha wants to merge 4 commits intorust-lang:mainfrom
Open
distinguish "expected a single argument" and "expected an argument" on attribute parsing#154827scrabsha wants to merge 4 commits intorust-lang:mainfrom
scrabsha wants to merge 4 commits intorust-lang:mainfrom
Conversation
rustbot
added
A-attributes
scrabsha
force-pushed
the
push-zuosxmmnzkrq
branch
2 times, most recently
from
2b3f438 to
436a3bb
Compare
This comment has been minimized.
This comment has been minimized.
scrabsha
force-pushed
the
push-zuosxmmnzkrq
branch
2 times, most recently
from
b99582a to
61551e5
Compare
scrabsha
commented
Apr 5, 2026
scrabsha
commented
Apr 5, 2026
This comment has been minimized.
This comment has been minimized.
scrabsha
force-pushed
the
push-zuosxmmnzkrq
branch
from
61551e5 to
c76706b
Compare
This comment has been minimized.
This comment has been minimized.
scrabsha
force-pushed
the
push-zuosxmmnzkrq
branch
3 times, most recently
from
8fdfe78 to
cd2de6a
Compare
scrabsha
commented
Apr 6, 2026
| let Some(arg) = args.list().and_then(MetaItemListParser::single) else { | ||
| let attr_span = cx.attr_span; | ||
| cx.adcx().expected_single_argument(attr_span); | ||
| cx.adcx().expected_single_argument(attr_span, 2); |
Contributor
Author
There was a problem hiding this comment.
This is technically incorrect, but fixed two commits later.
scrabsha
force-pushed
the
push-zuosxmmnzkrq
branch
from
cd2de6a to
9173a9b
Compare
This comment has been minimized.
This comment has been minimized.
scrabsha
force-pushed
the
push-zuosxmmnzkrq
branch
from
9173a9b to
1d395f3
Compare
This comment has been minimized.
This comment has been minimized.
scrabsha
force-pushed
the
push-zuosxmmnzkrq
branch
from
1d395f3 to
ec3f438
Compare
Contributor
Author
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit is the real thing, the commits that follow are refactorings of patterns i kept noticing.
Renders as:
