Skip to content

Handle RTN projections in assoc type restriction diagnostics#154932

Open
TaKO8Ki wants to merge 3 commits intorust-lang:mainfrom
TaKO8Ki:fix-152887-rtn-assoc-type-name
Open

Handle RTN projections in assoc type restriction diagnostics#154932
TaKO8Ki wants to merge 3 commits intorust-lang:mainfrom
TaKO8Ki:fix-152887-rtn-assoc-type-name

Conversation

@TaKO8Ki
Copy link
Copy Markdown
Member

@TaKO8Ki TaKO8Ki commented Apr 7, 2026

Fixes #152887

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Apr 7, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 7, 2026

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 10 candidates

Copy link
Copy Markdown
Member

@fmease fmease Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

View changes since the review

As I said before, could you please further reduce any potential reproducers if they're not minimal enough yet (e.g., by removing unnecessary elements and unnecessary user errors)?

This would be tremendously helpful for other contributors to reason about it. They might want to extend this test file with more test cases years down the line or they see this test failing after modifying the compiler in which case it's very beneficial if the test is easy to digest instead of being a giant blob you first have to wade through. The extra fluff certainly won't increase test coverage by much.

E.g., the code below can be shrunk to the following (maybe even further) while still reproducing the ICE:

#![feature(return_type_notation)]

pub trait Trait { async fn func(); }

impl<T: Trait<func(..): Send>> Trait for T {}

fn check(_: impl Trait) {}

fn main() { check(()); }

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. Sorry, I completely missed your earlier comment. I’ll reduce the reproducers further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ICE]: item_name: no name for DefPath

4 participants