Don't try to remove drop_in_place calls in RemoveUnneededDrops#155044
Open
WaffleLapkin wants to merge 1 commit intorust-lang:mainfrom
Open
Don't try to remove drop_in_place calls in RemoveUnneededDrops#155044WaffleLapkin wants to merge 1 commit intorust-lang:mainfrom
drop_in_place calls in RemoveUnneededDrops#155044WaffleLapkin wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rustbot
added
S-waiting-on-review
WaffleLapkin
commented
Apr 9, 2026
Comment on lines
6
to
12
| unsafe fn slice_in_place(ptr: *mut [char]) { | ||
| // CHECK-LABEL: fn slice_in_place(_1: *mut [char]) | ||
| // CHECK: bb0: { | ||
| // CHECK-NEXT: return; | ||
| // CHECK: bb0: { | ||
| // CHECK-NEXT: StorageLive(_2); | ||
| // CHECK-NEXT: _2 = copy _1; | ||
| // CHECK-NEXT: StorageDead(_2); | ||
| // CHECK-NEXT: return; | ||
| // CHECK-NEXT: } | ||
| std::ptr::drop_in_place(ptr) | ||
| } |
Member
Author
There was a problem hiding this comment.
idk how this used to pass, given that the diff is unchanged...
Member
There was a problem hiding this comment.
You removed the compile-flags, so that probably impacted it? The filecheck validations are on final mir always...
scottmcm
approved these changes
Apr 9, 2026
| @@ -1,12 +1,14 @@ | |||
| //@ test-mir-pass: RemoveUnneededDrops | |||
| //@ test-mir-pass: Inline | |||
Member
There was a problem hiding this comment.
Suggestion: now that this isn't a different pass, maybe move it into https://github.com/rust-lang/rust/tree/main/tests/mir-opt/inline? Could rename it to inline_empty_drop_glue or something too, to make it clearer what the goal is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per my justification in #154327 (comment)
r? scottmcm