Prevent line data from being discarded on resize.#616
Merged
parisk merged 1 commit intoxtermjs:masterfrom Mar 20, 2017
LucianBuzzo:crop-lines
Merged
Prevent line data from being discarded on resize.#616parisk merged 1 commit intoxtermjs:masterfrom LucianBuzzo:crop-lines
parisk merged 1 commit intoxtermjs:masterfrom
LucianBuzzo:crop-lines
Conversation
parisk
approved these changes
Mar 20, 2017
Contributor
parisk
left a comment
parisk
left a comment
There was a problem hiding this comment.
Code LGTM and works great 👍
Contributor
|
Thanks for this @LucianBuzzo! |
Closed
Contributor
|
@parisk, is it possible to cut a bug fix release with this change? |
Contributor
|
@blink1073 this cannot happen, since we have pushed several commits with "new features" after we issued the release, so this wouldn't be a pure bugfix release. You can either clone the repo and build it on your own, or just wait until the first week of April, for the 2.5 release. |
Contributor
|
No worries, had to ask 😉. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the core issues I'm trying to address in this PR #609 is that xterm.js will discard line data when resizing to smaller widths. As the discussion around reflow behaviour and architecture is still ongoing and may be for some time yet, I'm submitting this PR as an interim fix.
This PR prevents the character discard and uses behaviour similar to hyperterm.