Fixed mixins.startup.serve UnboundLocalError.#2992
Merged
ahopkins merged 2 commits intosanic-org:mainfrom Dec 31, 2024
Merged
Conversation
pygeek
force-pushed
the
fix-startup-serve
branch
2 times, most recently
from
7f02bc3 to
fe55023
Compare
pygeek
changed the title
pygeek
changed the title
pygeek
changed the title
Contributor
Author
|
There do not seem to be existing tests that specifically test the functionality of |
pygeek
force-pushed
the
fix-startup-serve
branch
from
fe55023 to
aad408a
Compare
pygeek
changed the title
pygeek
changed the title
mixins.startup.serve UnboundLocalError.
pygeek
force-pushed
the
fix-startup-serve
branch
2 times, most recently
from
9ddf8bd to
6d80c7e
Compare
pygeek
force-pushed
the
fix-startup-serve
branch
from
6d80c7e to
0d7b2ae
Compare
Contributor
Author
|
Type error being raised by CI by line 724 of Same for the 8 other mypy type-check errors. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2992 +/- ##
=============================================
- Coverage 87.617% 87.451% -0.167%
=============================================
Files 101 101
Lines 7575 7666 +91
Branches 1329 1350 +21
=============================================
+ Hits 6637 6704 +67
- Misses 641 661 +20
- Partials 297 301 +4 ☔ View full report in Codecov by Sentry. |
Member
|
How did you come by this error? |
Member
There seems to be a repro in the linked issue (I haven't tested it) |
ahopkins
approved these changes
Dec 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2985
the
finallyblock inmixins.servereferences a variable that is only defined in thetryblock. This results in aUnboundLocalErrorwithin thefinallyblock.