chat: always apply prompt file and auto-attach instructions. Fix #271624 #272020
+3
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #271624 by ensuring that prompt file and auto-attach instructions are always applied during chat widget processing, regardless of whether the view model is in editing mode.
Key changes:
- Removed the conditional check that prevented prompt file and auto-attach instruction processing when
viewModel.editingwas true
justschen
approved these changes
Oct 21, 2025
Collaborator
justschen
left a comment
justschen
left a comment
There was a problem hiding this comment.
great catch, this makes sense. not sure why i had that disabled when editing. Thanks!
Tyriar
approved these changes
Oct 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always apply prompt file and auto-attach instructions. Fix #271624.