Skip to content

Conversation

@chrmarti
Copy link
Collaborator

@chrmarti chrmarti commented Nov 2, 2025

Copilot AI review requested due to automatic review settings November 2, 2025 20:31
@chrmarti chrmarti enabled auto-merge (rebase) November 2, 2025 20:31
@chrmarti chrmarti self-assigned this Nov 2, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for loading system certificates using Node.js built-in TLS API (tls.getCACertificates('system')) as an alternative to the existing @vscode/proxy-agent implementation. The feature is controlled by a new experimental setting http.systemCertificatesNode.

  • Introduces a new configuration option http.systemCertificatesNode (default: false, experimental)
  • Updates certificate loading logic in both RequestService and proxyResolver to use Node.js native API when enabled
  • Updates @types/node to version ^22.18.10 to support the new TLS API

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/vs/platform/request/common/request.ts Adds http.systemCertificatesNode setting configuration and includes it in USER_LOCAL_AND_REMOTE_SETTINGS
src/vs/platform/request/node/requestService.ts Implements Node.js-based certificate loading in loadCertificates() method and updates getConfigValue() to support fallback values
src/vs/workbench/api/node/proxyResolver.ts Updates loadAdditionalCertificates to use Node.js system certificates for both remote and local scenarios when the setting is enabled
package.json Updates @types/node dependency to ^22.18.10
package-lock.json Updates lockfile for @types/node and its dependency undici-types

justschen
justschen previously approved these changes Nov 2, 2025
@justschen
Copy link
Collaborator

@chrmarti looks like compile/hygiene failed

@chrmarti chrmarti force-pushed the chrmarti/bad-badger branch from 0cf6b7c to 2197b31 Compare November 2, 2025 21:21
@vs-code-engineering
Copy link

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@bpasero

Matched files:

  • src/bootstrap-fork.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants