Repository navigation
gh-156365: Fix socket leak and stalled accept in the asyncio proactor server - #156366
Open
tonghuaroot wants to merge 1 commit into
Open
tonghuaroot wants to merge 1 commit into
tonghuaroot wants to merge 1 commit into
Conversation
tonghuaroot
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
August 25, 2026 13:38
OsmnvAslan
reviewed
Oct 26, 2026
OsmnvAslan
left a comment
Contributor
There was a problem hiding this comment.
Ran this locally: it merges cleanly into current main, test_asyncio passes, and both new tests fail without the fix. It matches the selector change from gh-155934, so LGTM.
One small thing: the new context = {...} inside loop() shadows the context parameter of _start_serving(). It's unused in the proactor path right now, so nothing breaks, but renaming it (e.g. exc_context) would avoid a surprise if context=context is ever passed to the transport here like in the selector version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BaseProactorEventLoop._start_serving()ranprotocol_factory()and transport creation in the accept callback guarded only byexcept OSError/except CancelledError. A per-connection failure therefore leaked the accepted socket and either stopped the accept loop (non-OSError) or closed the listening socket (OSError).Wrap the per-connection setup so the accepted socket is closed and the error is reported to the loop exception handler, while accept-stage errors keep their existing handling. This is the proactor counterpart of gh-155934 (selector) and gh-153133 (
create_connection).The added regression tests fail without the fix and pass with it; the full
test_asynciosuite passes.