[#117392] [Ruby master Feature#20405] Inline comments — "nobu (Nobuyoshi Nakada) via ruby-core" <ruby-core@...>

Issue #20405 has been reported by nobu (Nobuyoshi Nakada).

11 messages 2024/04/01

[#117434] [Ruby master Bug#20409] Missing reporting some invalid breaks — "kddnewton (Kevin Newton) via ruby-core" <ruby-core@...>

Issue #20409 has been reported by kddnewton (Kevin Newton).

8 messages 2024/04/03

[#117458] [Ruby master Bug#20414] `Fiber#raise` should recurse to `resumed_fiber` rather than failing. — "ioquatix (Samuel Williams) via ruby-core" <ruby-core@...>

Issue #20414 has been reported by ioquatix (Samuel Williams).

10 messages 2024/04/07

[#117469] [Ruby master Feature#20415] Precompute literal String hash code during compilation — "byroot (Jean Boussier) via ruby-core" <ruby-core@...>

Issue #20415 has been reported by byroot (Jean Boussier).

10 messages 2024/04/09

[#117494] [Ruby master Bug#20421] String#index and String#byteindex don't clear `$~` when offset > size (or bytesize) — "andrykonchin (Andrew Konchin) via ruby-core" <ruby-core@...>

Issue #20421 has been reported by andrykonchin (Andrew Konchin).

7 messages 2024/04/11

[#117498] [Ruby master Feature#20425] Optimize forwarding callers and callees — "tenderlovemaking (Aaron Patterson) via ruby-core" <ruby-core@...>

Issue #20425 has been reported by tenderlovemaking (Aaron Patterson).

14 messages 2024/04/11

[#117531] [Ruby master Bug#20431] Ruby 3.3.0 build fail with make: *** [io_buffer.o] Error 1 — "shubham_yadav (Shubham Yadav) via ruby-core" <ruby-core@...>

SXNzdWUgIzIwNDMxIGhhcyBiZWVuIHJlcG9ydGVkIGJ5IHNodWJoYW1feWFkYXYgKFNodWJoYW0g

11 messages 2024/04/16

[#117564] [Ruby master Bug#20433] Hash.inspect for some hash returns syntax invalid representation — "tompng (tomoya ishida) via ruby-core" <ruby-core@...>

Issue #20433 has been reported by tompng (tomoya ishida).

15 messages 2024/04/17

[#117572] [Ruby master Misc#20435] DevMeeting-2024-06-13 — "mame (Yusuke Endoh) via ruby-core" <ruby-core@...>

Issue #20435 has been reported by mame (Yusuke Endoh).

12 messages 2024/04/17

[#117588] [Ruby master Misc#20436] DevMeeting at RubyKaigi 2024 — "ko1 (Koichi Sasada) via ruby-core" <ruby-core@...>

SXNzdWUgIzIwNDM2IGhhcyBiZWVuIHJlcG9ydGVkIGJ5IGtvMSAoS29pY2hpIFNhc2FkYSkuDQoN

14 messages 2024/04/18

[#117624] [Ruby master Bug#20440] `super` from child class passing keyword arg as Hash if in a method with passthrough args called from base class — "ozydingo (Andrew Schwartz) via ruby-core" <ruby-core@...>

Issue #20440 has been reported by ozydingo (Andrew Schwartz).

7 messages 2024/04/20

[#117644] [Ruby master Feature#20443] Allow Major GC's to be disabled — "eightbitraptor (Matthew Valentine-House) via ruby-core" <ruby-core@...>

Issue #20443 has been reported by eightbitraptor (Matthew Valentine-House).

25 messages 2024/04/22

[#117646] [Ruby master Bug#20444] Kernel#loop: returning the "result" value of StopIteration doesn't work when raised directly — "esad (Esad Hajdarevic) via ruby-core" <ruby-core@...>

Issue #20444 has been reported by esad (Esad Hajdarevic).

9 messages 2024/04/22

[#117653] [Ruby master Bug#20446] OUtdated https://cache.ruby-lang.org/pub/ruby/index.txt — "vo.x (Vit Ondruch) via ruby-core" <ruby-core@...>

Issue #20446 has been reported by vo.x (Vit Ondruch).

7 messages 2024/04/23

[#117657] [Ruby master Bug#20447] Ruby 3.3.1 broken on i686 — "vo.x (Vit Ondruch) via ruby-core" <ruby-core@...>

SXNzdWUgIzIwNDQ3IGhhcyBiZWVuIHJlcG9ydGVkIGJ5IHZvLnggKFZpdCBPbmRydWNoKS4NCg0K

15 messages 2024/04/23

[#117658] [Ruby master Feature#20448] Make coverage event hooking C API public — "ms-tob (Matt S) via ruby-core" <ruby-core@...>

Issue #20448 has been reported by ms-tob (Matt S).

9 messages 2024/04/23

[#117674] [Ruby master Bug#20450] Ruby 3.1.1 broken with bootsnap — "philippe.bs.noel@... (Philippe Noel) via ruby-core" <ruby-core@...>

Issue #20450 has been reported by [email protected] (Philippe Noel).

11 messages 2024/04/24

[#117684] [Ruby master Bug#20452] Ruby 3.3 on Alpine Linux results in a relatively shallow SystemStackError exception — "Earlopain (A S) via ruby-core" <ruby-core@...>

Issue #20452 has been reported by Earlopain (A S).

12 messages 2024/04/24

[#117711] [Ruby master Bug#20456] Hash can get stuck marked as iterating through process forking — "blowfishpro (Talia Wong) via ruby-core" <ruby-core@...>

Issue #20456 has been reported by blowfishpro (Talia Wong).

7 messages 2024/04/25

[ruby-core:117442] [Ruby master Feature#20351] Optionally extract common GC routines into a DSO

From: "eightbitraptor (Matthew Valentine-House) via ruby-core" <ruby-core@...>
Date: 2024-04-04 20:03:15 UTC
List: ruby-core #117442
Issue #20351 has been updated by eightbitraptor (Matthew Valentine-House).


Based on feedback from @katei and @nobu we have changed our approach to this project.

An updated PR can be found here: [[GH #10456]](https://github.com/ruby/ruby/pull/10456)

Instead of building the Ruby GC as a shared object in order to override it using `LD_LIBRARY_PATH`/`LD_PRELOAD` et al, and after experimenting with some alternative approaches we have decided to use an approach based around the `dlopen` wrappers provided in `dln.c`. This provides several benefits that our existing implementation does not.

- It does not require integration of another shared object into the build system. As pointed out by @katei, this is a complex and error-prone task, with added complexity implications for committers building and testing new features on Ruby, as well as an explosion of new CI tasks required to test all variants.
- It doesn't expose the GC as a shared object, with the potentially misleading consequence of users assuming they can link against the Ruby GC independently; as they currently can with `libruby` 
- It runs on more platforms than our initial approach which was targeted specifically at Linux and MacOS. The use of existing functionality in `dln.c` should allow development of this feature on any platform that supports C extensions.

The approach taken here is as follows:

- Enable this feature by configuring with `--with-shared-gc`
- When enabled, Ruby will check for the presence of the environment variable `RUBY_GC_LIBRARY_PATH`
- If that path exists and points to a valid shared object
  - Open the shared object (using `dln_open`), and map the `Init_GC` function to a function map
  - call `Init_GC` as part of `rb_objspace_alloc` when initialising the GC
- If that path does not point to a valid shared object
  - Degrade gracefully to initialising the existing Ruby objspace and GC
  
When Ruby is configured without the `--with-shared-gc` flag, no extra code is compiled and so existing behaviour is maintained without any performance penalty.

Enabling this feature, but not populating `RUBY_GC_LIBRARY_PATH` will incur a small performance penalty due to the overhead of using `getenv` to check for the environment variable.

The use of `dln.c` rather than using `dlopen` directly, should enable this feature to be supported on all platforms that support loading shared libraries, rather than the initial implementation, which explicitly only supported Linux and MacOS.

----------------------------------------
Feature #20351: Optionally extract common GC routines into a DSO
https://bugs.ruby-lang.org/issues/20351#change-107823

* Author: eightbitraptor (Matthew Valentine-House)
* Status: Open
----------------------------------------
[Github PR#10302](https://github.com/ruby/ruby/pull/10302)

**NOTE: This proposal does not change the default build of Ruby, and therefore
should NOT cause performance degradation for Ruby built in the usual way**

Our long term goal is to standardise Ruby's GC interface, allowing alternative
GC implementations to be used. This will be acheived by optionally building
Ruby's GC as a shared object; enabling it to be replaced at runtime using using
`LD_LIBRARY_PATH`. eg:

```
LD_LIBRARY_PATH=/custom_gc_location ruby script.rb
```

This ticket proposes the first step towards this goal. A new experimental build
option, `--enable-shared-gc`, that will compile and link a module into the built
`ruby` binary as a shared object - `miniruby` will remain statically linked to
the existing GC in all cases.


Similar methods of replacing functionality relied on by Ruby have
precedent. `jemalloc` uses `LD_PRELOAD` to replace `glibc` provided `malloc` and
`free` at runtime. Although this project will be the first time a technique such
as this has been used to replace core Ruby functionality.

This flag will be marked as experimental & **disabled by default**.

[The PR linked from this ticket](https://github.com/ruby/ruby/pull/10302) implements the new build flag, along with the
absolute minimum code required to test it's implementation (a single debug
function).

The implementation of the new build flag is based on the existing implementation
of `--enable-shared` and behaves as follows:

- `--enable-shared --enable-shared-gc`
  
  This will build both `libruby` and `librubygc` as shared objects. `ruby` will
  link dynamically to both `libruby` and `librubygc`.
  
- `--disable-shared --enable-shared-gc`

  This will build `librubygc` as a shared object, and build `libruby` as a
  static object. `libruby` will link dynamically to `librubygc` and `ruby` will
  be statically linked to `libruby`.
  
- `--disable-shared-gc`

  **This will be the default**, and when this case is true the build behaviour
  will be exactly the same as it is currently. ie. the existing Ruby GC will be
  built and linked statically into either `ruby` or `libruby.so` depending on
  the state of `--enable-shared`.
  
We are aware that there will be a small performance penalty from moving the GC
logic into a shared object, but this is an opt-in configuration turned on at
build time intended to be used by experienced users. 

Still, we anticipate that, even with this configuration turned on, this penalty
will be negligible compared the the benefit that being able to use high
performance GC algorithms will provide.

This performance penalty is also the reason that **this feature will be disabled
by default**. There will be no performance impact for anyone compiling Ruby in
the usual manner, without explicitly enabling this feature.

We have discussed this proposal with @matz who has approved our work on this
project - having a clear abstraction between the VM and the GC will enable us to
iterate faster on improvements to Ruby's existing GC.

## Motivation

In the long term we want to provide the ability to override the current Ruby GC
implementation in order to:

* Experiment with modern high-performance GC implementations, such as Immix, G1,
  LXR etc.
* Easily split-test changes to the GC, or the GC tuning, in production without
  having to rebuild Ruby
* Easily use debug builds of the GC to help identify production problems and
  bottlenecks without having to rebuild Ruby
* Encourage the academic memory management research community to consider Ruby
  for their research (the current work on [MMTk & Ruby](https://github.com/mmtk/mmtk-ruby) is a good example of
  this).

## Future work

The initial implementation of the shared GC module in this PR is deliberately
small, and exists only for testing the build system integration.

The next steps are to identify boundaries between the GC and the VM and begin to
extract common functionality into this GC wrapper module to serve as the
foundation of our GC interface.

## Who's working on this
  
- @eightbitraptor
- @tenderlovemaking 
- @peterzhu2118
- @eileencodes



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- [email protected]
 To unsubscribe send an email to [email protected]
 ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/

In This Thread